Repository navigation
Conversation
gix was the first choice: it is pure Rust and has what upcoming work needs. git2 was picked only to apply expected-failure patches, and Nix can apply those itself. gix parses every revision form natively, so our hand-written ^X, X^! and X^@ handling is gone. Tests are unchanged and still build fixtures with git2, which shows behaviour is the same.
Rewrite the test fixtures with gix and drop git2 as a dev-dependency, so libgit2 is no longer built at all. Each test keeps the same steps and assertions.
std already prints an exit status as "exit status: 1" or as the signal that stopped the process, so the hand-written status_suffix is gone. Error messages now end with ": exit status: 1" instead of " with exit status 1".
Mshehu5
force-pushed
the
commit-validation-gix
branch
from
November 13, 2026 15:39
5c2e1a3 to
d479778
Compare
oakagent
reviewed
Nov 14, 2026
| for reference in references.all().context(Error::WalkHistory)? { | ||
| let mut reference = reference.context(Error::WalkHistory)?; | ||
| // As with `git rev-list --all`, refs to non-commit objects are ignored. | ||
| if let Ok(commit) = reference.peel_to_commit() { |
There was a problem hiding this comment.
Broken refs are silently skipped by --all
if let Ok discards every peel error, not only the non-commit refs named by the comment, so a ref whose object is missing is dropped and --all exits successfully over an incomplete history; the parent returned WalkHistory for the same ref.
oak · automated · d479778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves from git2 to gix for reading the repository.
gix was the first choice: it's a pure Rust library that is easier to
work with, and it's what jj-lib is built on, if we want to add
something like that in the future.
passing them shows nothing changed.