Repository navigation
Conversation
The CLI tests used a fake nix script, so they never ran a real flake check. They now run real `nix flake check` on a tiny fixture flake whose check just passes or fails. Commit selection tests moved to unit tests in src/history.rs
oakagent
reviewed
Nov 14, 2026
| String::from_utf8_lossy(&output.stderr) | ||
| assert_eq!(validated(&output), [first, second]); | ||
| assert_eq!(fixture.repository.head().unwrap().target().unwrap(), head); | ||
| assert_eq!( |
There was a problem hiding this comment.
Checkout test omits index and untracked files
For checkout preservation, the test checks HEAD and flake.nix only; the removed assert_checkout also compared the index bytes and an untracked file.
oak · automated · da3c5e8
| @@ -0,0 +1,27 @@ | |||
| { | |||
| outputs = | |||
There was a problem hiding this comment.
Lock-file flag no longer tested
The fixture flake has no inputs, so the new tests never assert --no-update-lock-file or a lock-file update; the removed fake-Nix test asserted it explicitly.
oak · automated · da3c5e8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
The CLI tests used a fake
nixscript, so they never ran a real flakecheck. Now:
nix flake checkon a tiny fixture flake(
tests/flakes/flake.nix) whose check just passes or fails. Theycheck that each commit's own flake is checked, that the run stops at
the first failure, and that shallow clones work.
src/history.rs