Repository navigation
Conversation
yuval-block
left a comment
There was a problem hiding this comment.
only skimmed, didn't scrutinize
- please make main.rs a thin wrapper around a testable lib.rs
- use jj-lib, gitoxide or gitlib2 (different tradeoffs we can discuss) instead of parsing git cli output
- avoid stringly typed data in rust, main advantage over say python is we can define clean algebraic data types for everything
- avoid external commands for things like mktemp, equivalent rust code will be cleaner and more portable & reliable
- split flake.nix into separate flake parts, flake.nix itself should be minimal composition of parts coming from the repo
- use crane and rust-overlay
- avoid README.md for now let's first figure out what we want the code to be then document it
f2cff7d to
bdcf212
Compare
|
Addressed comment |
bdcf212 to
fc277ce
Compare
| edition = "2024" | ||
| description = "Run Nix flake checks for every commit in a revision range" | ||
| license = "MIT" | ||
| repository = "https://github.com/Mshehu5/validate-commits" |
There was a problem hiding this comment.
The repository field points to the personal fork https://github.com/Mshehu5/validate-commits instead of the canonical project repository fungi-protocol/validate-commits that this PR targets, so crate metadata directs tooling and users to a fork rather than the project home.
| } | ||
| } | ||
|
|
||
| fn history_commit(fixture: &Fixture, message: &str, parents: &[ObjectId]) -> ObjectId { |
There was a problem hiding this comment.
history_commit and assert_symmetric_difference are added but no #[test] in this file calls either helper, so cargo test emits dead_code warnings on every build and the symmetric-difference (A...B / Spec::Merge) coverage they were written for never executes.
| contents: read | ||
|
|
||
| jobs: | ||
| checks: |
There was a problem hiding this comment.
The checks job sets no timeout-minutes, so a hung step (e.g. a stalled nix flake check build or substituter) runs until GitHub's hosted-runner default of 360 minutes cancels it; an explicit bound would cap wasted runner time.
fc277ce to
8dcb00f
Compare
8dcb00f to
ca081f4
Compare
|
replaced by #4 |
This PR sets up the Rust project and implements the first commit-validation MVP. The CLI accepts a Git revision range, runs nix flake check on each commit in order, and stops on the first failure. tests for the main validation flow and minimum CI.