Repository navigation
Add an overview - #51
yuval-block wants to merge 2 commits into
Conversation
arminsabouri
left a comment
There was a problem hiding this comment.
This walks a thin line between describing the solutions and the techincal "how" (as well as what the problems). My comments are mostly regarding continuitity / flow of ideas.
|
|
||
| ### Communication models | ||
|
|
||
| There are three communication models traditionally described in distributed systems: asynchrony, partial synchrony and synchrony. Each model demands a different approach to fault tolerance. |
There was a problem hiding this comment.
nit: We either need a leading sentence that connects this section with the one before or just remove it or condense it into 2 sentences into the last section. e.g the interactive tx construction protocols may operate in these communication models blah blah it matters bc X.
There was a problem hiding this comment.
Edit: now that I see how the rest of the document builds these terms, I think its approriate to define them here. But a connector sentence would still cause less "whip lash" .
|
|
||
| ## Net settlement | ||
|
|
||
| Net settlement interactively combines several payments into one transaction. Individual payment amounts need not appear on chain, and payments may form cycles. |
There was a problem hiding this comment.
Same comment about a connector sentence for this as well.
2f2a706 to
327b453
Compare
8f2ce4c to
76631c2
Compare
arminsabouri
left a comment
There was a problem hiding this comment.
just noticed this. Have not read the rest of this
9508302 to
f9a0ded
Compare
arminsabouri
left a comment
There was a problem hiding this comment.
This reads well! I need to re-read the cordial miners / consitency section again. There is a lot of information packed in there that I am mainly not familiar with. But I think it gets the why across which is the important bit for this document.
|
about the links, we can:
i'm leaning towards the latter, and after we're done with the backlog we can add a nix flake check that ensures there are no broken links... wdyt @bc1cindy ? |
range-diff for force push f9a0ded9d9 → 36dbec85c3
|
range-diff for force push 36dbec85c3 → c3a0f8d3da
|
agreed, merge with broken links and #54 tracks adding the check once the backlog lands non-blocking, but since the chapters move into |
|
range-diff for force push dc99513d04 → f22253b13c
|
range-diff for force push f22253b13c → 6bc209f822
|
range-diff for force push 6bc209f822 → e442a6cc15
|
|
@yuval-block
|
|
|
||
| Net settlement adds both safety and liveness considerations. Before signing, a participant must know that its funds reach the intended destinations. It can check outputs returning funds to itself directly; for a payment, it needs the payee to confirm that the transaction satisfies their agreement. This can add sequential dependencies between peers. Within each payment cycle at least one party will receive as much as it sends or more, and can therefore safely initiate a cascade of confirmations. See the [concurrent PSBT specification](./psbt-concurrent.md#confirmation-of-successful-payment-prior-to-signing) for additional details. |
range-diff for force push e442a6cc15 → 9b8443b67f
|
| # Protocol Suite | ||
|
|
||
| * [Overview](overview.md) - Collaborative transaction construction, privacy, fault tolerance and coalition formation. | ||
| * [Abstract transport interfaces](transport-interfaces.md) - Send, receive and bidirectional channels, the kinds of messaging the protocol needs, and broadcast built from peer to peer channels. |
There was a problem hiding this comment.
Index omits marker from five LLM chapters
The README note says 🤖 marks LLM output, but the index entries for transport-interfaces.md, contacts.md, transaction-construction.md, block-dag.md and recovery-track.md omit the marker their pages carry, so the generated SUMMARY.md and contents.md lose that provenance.
oak · automated · 9b8443b
9b8443b to
6a66aa5
Compare
range-diff for force push 9b8443b67f → 6a66aa533b
|
6a66aa5 to
236236b
Compare
range-diff for force push 6a66aa533b → 236236ba4e
|
1 similar comment
range-diff for force push 6a66aa533b → 236236ba4e
|
This includes a high level description of the various components of the protocol suite, focusing on the transaction construction. Unlike the strawman ladder it replaced (previously described as an overview, and now somewhat out of date at any rate) it is scoped to only discuss actual things not strawman constructions which only benefit exposition, to avoid confusion about what is actually being implemented. Closes #21
236236b to
e4de96a
Compare
range-diff for force push 236236ba4e → e4de96adeb
|
|
@yuval-block
|
This includes a high level description of the various components of the
protocol suite, focusing on the transaction construction.
Unlike the strawman ladder it replaced (previously described as an
overview, and now somewhat out of date at any rate) it is scoped to only
discuss actual things not strawman constructions which only benefit
exposition, to avoid confusion about what is actually being implemented.
Closes #21