Repository navigation
property test for joinable_struct! conflict visitor - #93
Open
yuval-block wants to merge 1 commit into
Open
yuval-block wants to merge 1 commit into
yuval-block wants to merge 1 commit into
Conversation
for_each_conflict was only covered by a unit test where every field conflicts. Check against arbitrary pairs of samples that it visits exactly the disagreeing scalar, option and map entries, in field then key order, with the map key passed through, and that is_ok and try_unwrap agree with it. Split the macro tests into unit and prop modules and enable the test module under either feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ACK d6d6e70
|
bc1cindy
approved these changes
Nov 14, 2026
|
ACK d6d6e70
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #68. The property was written in response to review on #68, but #68 was merged before it was pushed.
for_each_conflictwas only covered by a unit test where every field conflicts. This adds a property over arbitrary pairs of small samples, so that clean and conflicted entries both show up in one join. It checks that the visitor reports exactly the disagreeing scalar, option and map entries, in field order and then key order, with the map key passed through. It also checks thatis_okandtry_unwrapagree with it.Before writing it I confirmed it catches two seeded mutants: one that always passes
Nonefor the map key, and one that stops after the first conflicted map entry.The macro tests are split into
unitandpropmodules, and the test module now compiles under either feature.🤖 Generated with Claude Code