Skip to content

Introduce joinable Input struct type - #75

Merged
arminsabouri merged 1 commit into
mainfrom
input-type
Nov 13, 2026
Merged

arminsabouri merged 1 commit into
mainfrom
input-type

Conversation

@yuval-block

Copy link
Copy Markdown
Collaborator

No description provided.

@github-code-quality

github-code-quality Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Rust

Rust / code-coverage/cargo-llvm-cov

main 227c7b5 input-type 1c5a69d +/-
100% 100% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 12, 2026 20:26 UTC

@github-actions

Copy link
Copy Markdown
range-diff for force push d795107cfc → f425f82d36 November 12, 2026 18:47 UTC: 1 modified; 1 commit; base 9d3ba507d1 → 94c1abc38e (diverged, 3 ahead and 1 behind)

reproduce: git range-diff 9d3ba50..d795107 94c1abc..f425f82

1:  d795107cfc +287 -32 6f ! 1:  f425f82d36 +287 -32 6f Introduce joinable Input struct type
1: d795107cfc ! 1: f425f82d36 Introduce joinable Input struct type
@@ crates/concurrent-psbt/src/psbt/input.rs (new)
 +        fn for_each_conflict_reports_every_conflicted_field() {
 +            let result = all_fields_conflict(1);
 +            let mut fields = Vec::new();
-+            result.for_each_conflict(|field, _| fields.push(field.to_owned()));
++            result.for_each_conflict(|field, _, _| fields.push(field.to_owned()));
 +
 +            assert_eq!(fields, ALL_CONFLICT_FIELDS);
 +        }

@github-actions

Copy link
Copy Markdown
range-diff for force push d795107cfc → f425f82d36 November 12, 2026 18:47 UTC: 1 modified; 1 commit; base 9d3ba507d1 → 94c1abc38e (diverged, 3 ahead and 1 behind)

reproduce: git range-diff 9d3ba50..d795107 94c1abc..f425f82

1:  d795107cfc +287 -32 6f ! 1:  f425f82d36 +287 -32 6f Introduce joinable Input struct type
1: d795107cfc ! 1: f425f82d36 Introduce joinable Input struct type
@@ crates/concurrent-psbt/src/psbt/input.rs (new)
 +        fn for_each_conflict_reports_every_conflicted_field() {
 +            let result = all_fields_conflict(1);
 +            let mut fields = Vec::new();
-+            result.for_each_conflict(|field, _| fields.push(field.to_owned()));
++            result.for_each_conflict(|field, _, _| fields.push(field.to_owned()));
 +
 +            assert_eq!(fields, ALL_CONFLICT_FIELDS);
 +        }

Base automatically changed from struct-macro to main November 12, 2026 19:36
@github-actions

Copy link
Copy Markdown
range-diff for force push f425f82d36 → 1c5a69d312 November 12, 2026 20:16 UTC: 1 modified; 1 commit; base 94c1abc38e → 227c7b51ba (descendant, 3 commits ahead)

reproduce: git range-diff 94c1abc..f425f82 227c7b5..1c5a69d

1:  f425f82d36 +287 -32 6f ! 1:  1c5a69d312 +287 -28 5f Introduce joinable Input struct type
1: f425f82d36 ! 1: 1c5a69d312 Introduce joinable Input struct type
@@ crates/concurrent-psbt/src/psbt/input.rs (new)
 +    }
 +}
 
- ## crates/concurrent-psbt/src/psbt/joinable_struct_macro.rs ##
-@@
- /// The field list must name at least one field: `is_ok` is generated as the
- /// conjunction of the per-field checks, which has no expansion for an empty
- /// list.
--#[cfg_attr(
--    not(all(test, feature = "unit-tests")),
--    expect(unused_macros, reason = "expanded by the PSBT field types")
--)]
- macro_rules! joinable_struct {
-     // ── Entry point ──────────────────────────────────────────
-     (
-
  ## crates/concurrent-psbt/src/psbt/mod.rs ##
 @@
  #[macro_use]
  mod joinable_struct_macro;
+ pub(crate) mod global;
 +pub mod input;
  mod values;

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1c5a69d

@arminsabouri arminsabouri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeACK

@arminsabouri
arminsabouri added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 543f744 Nov 13, 2026
6 checks passed
@arminsabouri
arminsabouri deleted the input-type branch November 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants