Skip to content

Introduce joinable Output struct type - #74

Merged
arminsabouri merged 1 commit into
struct-macrofrom
output-type
Nov 12, 2026
Merged

arminsabouri merged 1 commit into
struct-macrofrom
output-type

Conversation

@yuval-block

Copy link
Copy Markdown
Collaborator

No description provided.

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: Rust

Rust / code-coverage/cargo-llvm-cov

struct-macro 5346f2b output-type e99ad1e +/-
100% 100% 0%
View coverage of the 1 most impacted file.
File struct-macro 5346f2b output-type e99ad1e +/-
crates/concurre...struct_macro.rs 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

joinable_struct! {
/// Result-domain representation of a PSBT output.
///
/// Each field mirrors its counterpart in [`psbt_v2::v2::Output`] but is

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent-payments fields break Output join build

ResultOutput mirrors only the default psbt_v2::v2::Output fields; enabling psbt-v2/silent-payments adds sp_v0_info and sp_v0_label, so the macro's exhaustive try_unwrap initializer fails to compile with E0063.

oak · automated · e99ad1e

@arminsabouri arminsabouri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeACK. Missing some typed fields e.g sp, musig, etc... These can be ticketed and followed up on. Not a blocker

@arminsabouri
arminsabouri merged commit c5e4c44 into struct-macro Nov 12, 2026
5 checks passed
@arminsabouri
arminsabouri deleted the output-type branch November 12, 2026 14:39
@yuval-block

Copy link
Copy Markdown
Collaborator Author

i'm going to unmerge this and reopen, i couldn't stack it because the parent branch's PR has multiple children and it still needs updates, now this PR is a part of #68 which is a bit confusing

Mshehu5 pushed a commit to Mshehu5/concurrent-psbt that referenced this pull request Nov 14, 2026
Reopens fungi-protocol#74, which was merged into \`struct-macro\` before fungi-protocol#68 landed.
Same commit, now stacked on fungi-protocol#68.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants