Repository navigation
introduce joinable variant of PSBT Global struct - #72
Conversation
Code coverage overviewLanguages: Rust Rust / code-coverage/cargo-llvm-cov
View coverage of the 1 most impacted file.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
range-diff for force push 88f2159e3a → 2b2df2d609
|
range-diff for force push 2b2df2d609 → 53f1339f66
|
range-diff for force push 53f1339f66 → 9e4d035276
|
range-diff for force push 53f1339f66 → 9e4d035276
|
|
@yuval-block One open point:
The description:
|
arminsabouri
left a comment
There was a problem hiding this comment.
CodeACK
oakagent''s comment makes sense. There are some comments on #68 that should be resolved too. Then the whole stack can be merged
Add ResultGlobal and GlobalExt so PSBT global fields can be lifted into the result domain, where `Join` is available and works recursively. This is the first expansion of joinable_struct!. The module stays crate-private under a dead_code expectation until UnorderedPsbt composes it with the input and output sets and exports it. Input and output counts still join as scalar values here. The later UnorderedPsbt commit reconciles counts against the joined input and output sets, because that decision needs both collections in scope.
range-diff for force push 9e4d035276 → 1b728dcc94
|
range-diff for force push 9e4d035276 → 1b728dcc94
|
Add ResultGlobal and GlobalExt so PSBT global fields can be lifted into the result domain, where
Joinis available and works recursively.This is the first production expansion of joinable_struct!, so the collection lifting traits introduced earlier become live infrastructure here rather than dormant scaffolding, and their dead_code expectations are removed.
Input and output counts still join as scalar values here. The later UnorderedPsbt commit reconciles counts against the joined input and output sets, because that decision needs both collections in scope.