Repository navigation
introduce Lift and Conflicts traits to simplify struct macro - #121
Open
yuval-block wants to merge 1 commit into
Open
yuval-block wants to merge 1 commit into
yuval-block wants to merge 1 commit into
Conversation
Code coverage overviewLanguages: Rust Rust / code-coverage/cargo-llvm-cov
View coverage of the 8 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
yuval-block
marked this pull request as ready for review
November 16, 2026 00:29
yuval-block
marked this pull request as draft
November 16, 2026 02:16
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 03:12
439d9e2 to
b72b43e
Compare
range-diff for force push 439d9e2a38 → b72b43e9b8
|
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 03:31
b72b43e to
441292f
Compare
range-diff for force push b72b43e9b8 → 441292fb76
|
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 03:33
441292f to
4c1849a
Compare
range-diff for force push 441292fb76 → 4c1849a74d
|
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 03:39
4c1849a to
4bc24ca
Compare
range-diff for force push 4c1849a74d → 4bc24cac39
|
yuval-block
marked this pull request as ready for review
November 16, 2026 03:46
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 04:18
4bc24ca to
26f6320
Compare
range-diff for force push 4bc24cac39 → 26f6320adb
|
Choose each field's result type through Lift, so aliases and qualified Option, BTreeMap, and HashMap types behave like their underlying types. Generated PSBT records can themselves be wrapped inside these containers. Lift::wrap pairs with ResultWrapped::try_unwrap. Failed extraction retains the complete wrapped container, including its clean entries. Compose borrowed Conflicts iterators without erasing map keys or value types. Record conflict enums identify the field and any keydata, replacing the Debug-based callback visitor. Suggested-by: Codex Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yuval-block
force-pushed
the
joinable-struct-lift
branch
from
November 16, 2026 04:50
26f6320 to
0e4597c
Compare
range-diff for force push 26f6320adb → 0e4597c7b1
|
|
@yuval-block
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joinable_struct!previously chose each field's rules by matching how its type was spelled. Qualified paths and aliases of containers could therefore be treated as scalars.Lift::wrapnow selects the result-domain type through the field's type.PartialJoinvalues lift intoJoinResult;Option,BTreeMap, andHashMaplift their values recursively, including generated PSBT records.ResultWrapped::try_unwrapis the inverse operation when there are no conflicts. Failed extraction retains the whole wrapped container, including its clean entries. Taproot key-origin tuples use the existingIdempotentValuejoin with structural equality, replacing the special order-insensitive comparison.Conflictscomposes borrowed iterators without erasing conflict values or map keys. PSBT conflict enums identify fields and keydata, and enclosing containers retain the keys that locate each record. These replace theDebug-based callback visitor. The existing PSBT extension names remain aliases ofLift, preserving.wrap()call sites.record_conflicts!is a temporary addition, invoked byjoinable_struct!with explicit conflict mappings. Once #116 introduces our own PSBT structs,joinable_struct!will subsume it so one field declaration defines the source type, result type, and conflict variants.The borrowed conflict iterators address the introspection described in #44, with typed PSBT field paths and keydata.