Repository navigation
proprietary fields for unordered PSBT spec - #110
yuval-block wants to merge 2 commits into
Conversation
Code coverage overviewLanguages: Rust Rust / code-coverage/cargo-llvm-cov
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
fc9b919 to
86a484d
Compare
range-diff for force push fc9b919e82 → 86a484d169
|
range-diff for force push fc9b919e82 → 86a484d169
|
28d455e to
65a91c6
Compare
65a91c6 to
ae99e06
Compare
ae99e06 to
1227d3a
Compare
range-diff for force push ae99e06508 → 1227d3a5e5
|
1227d3a to
08c8dd4
Compare
range-diff for force push 1227d3a5e5 → 08c8dd432a
|
08c8dd4 to
1d68eb5
Compare
range-diff for force push 08c8dd432a → 1d68eb5c8c
|
1d68eb5 to
6266702
Compare
range-diff for force push 1d68eb5c8c → 62667029b5
|
range-diff for force push 1d68eb5c8c → 62667029b5
|
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum SortKeyDerivation { | ||
| /// `0x00`: every input and output needs an explicit sort key, and there is | ||
| /// no sort seed. |
There was a problem hiding this comment.
Explicit sort mode accepts and serializes a supplied seed
SortKeyDerivation::Explicit (0x00) documents that there is no sort seed, but Global::set_sort_seed/set_sort_key_derivation and Global::try_from accept a seed alongside it, and UnorderedPsbt::into_psbt serializes both.
oakagent · automated · 6266702
6266702 to
d7bcb09
Compare
65c2579 to
80ea45d
Compare
range-diff for force push 65c25793a5 → 80ea45da32
|
80ea45d to
00ec300
Compare
range-diff for force push 80ea45da32 → 00ec300c1b
|
00ec300 to
6dcdbc0
Compare
range-diff for force push 00ec300c1b → 6dcdbc01d9
|
range-diff for force push 00ec300c1b → 6dcdbc01d9
|
6dcdbc0 to
1f4cc5b
Compare
range-diff for force push 6dcdbc01d9 → 1f4cc5b213
|
1f4cc5b to
c42d27a
Compare
range-diff for force push 1f4cc5b213 → c42d27aab8
|
c42d27a to
cf4c10e
Compare
range-diff for force push c42d27aab8 → cf4c10eb8b
|
cf4c10e to
59080f8
Compare
range-diff for force push cf4c10eb8b → 59080f841c
|
59080f8 to
a4a0760
Compare
range-diff for force push 59080f841c → a4a076085e
|
a4a0760 to
78f9665
Compare
range-diff for force push a4a076085e → 78f9665f79
|
| /// | ||
| /// `0x01` = sort keys derived from seed (explicit keys MUST NOT be set). | ||
| /// `0x00` = explicit sort keys required. | ||
| pub const PSBT_GLOBAL_SORT_KEY_DERIVATION_SUBTYPE: u8 = 0x12; |
There was a problem hiding this comment.
Spec field name differs from code
The spec names this global field PSBT_GLOBAL_SORT_DETERMINISTIC; the new public constant, accessors, and error messages call it PSBT_GLOBAL_SORT_KEY_DERIVATION, so an implementer following the spec looks for a different field name and a rejected PSBT's error names a field absent from the spec.
PSBT_GLOBAL_SORT_DETERMINISTIC = TBD
oakagent · automated · 78f9665
No description provided.