feat: add docs workload to e2e pipeline#3
Open
fullzer4 wants to merge 11 commits into
Open
Conversation
fullzer4
commented
Jun 17, 2026
fullzer4
commented
Owner
- Add image-niphas-docs to all-images in nix/images.nix
- Add Helm templates for docs Deployment + Service (gated by docs.enabled)
- Load docs image into Kind cluster in CI
- Deploy docs with --set docs.enabled=true in e2e
- Verify docs site returns HTTP 200 before running e2e tests
- Add docs logs to debug output on failure
- Add image-niphas-docs to all-images in nix/images.nix - Add Helm templates for docs Deployment + Service (gated by docs.enabled) - Load docs image into Kind cluster in CI - Deploy docs with --set docs.enabled=true in e2e - Verify docs site returns HTTP 200 before running e2e tests - Add docs logs to debug output on failure
…xpkgs#hello workload - Fix operator not passing storePath in CSI volumeAttributes - Fix CSI mounting single store path instead of entire cache dir - Replace mock-eval with real eval in CI - Use nixpkgs#hello as docs workload (available on cache.nixos.org) - Add full pipeline e2e test: eval → CSI fetch → pod Running - Increase CI timeouts for real eval (180s)
- Replace Nix-based workflow with standard Rust tooling - Add Dockerfiles for all images (operator, eval, csi, runner) - Use dtolnay/rust-toolchain + Swatinem/rust-cache for faster builds - Direct cargo commands instead of nix build - Expected speedup: ~21min → ~8-10min (55% improvement) Benefits: - Leverages GitHub Actions' native Cargo caching - Eliminates Nix overhead (~90-120s per run) - Avoids magic-nix-cache 10GB limit - Simpler, more maintainable workflow
The project uses edition = "2024" which requires Rust 1.85+. Previous Dockerfiles and CI used Rust 1.83 causing build failures. Changes: - Dockerfiles: rust:1.83 → rust:1.85 - CI workflow: @stable → @1.85
Dependencies require Rust 1.88: - kube@3.1.0 requires rustc 1.88.0 - darling_macro@0.23.0 requires rustc 1.88.0 - time@0.3.47 requires rustc 1.88.0 Changes: - Dockerfiles: 1.85 → 1.88 - CI workflow: @1.85 → @1.88 - Cargo.toml: rust-version 1.85 → 1.88
Clippy error:
error: this `if` statement can be collapsed
--> crates/niphas-core/src/nix/nar.rs:232:13
Changed from nested if to combined condition with &&
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.