You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Three small hardening items that came up while reviewing #1406 and #1409. Each is small; they're grouped so they don't get lost.
Production Dockerfiles use nightly base images.src/Host/FSH.Starter.Api/Dockerfile and src/Host/FSH.Starter.DbMigrator/Dockerfile use FROM mcr.microsoft.com/dotnet/nightly/aspnet:10.0-noble-chiseled. That line came in with 59b513e ("bump bases off preview"), when .NET 10 was still in preview. Nightly images are unsupported and can change under you. Move to mcr.microsoft.com/dotnet/aspnet:10.0-noble-chiseled. While at it, note the drift: the csproj ContainerFamily (SDK container publish, used for AWS) is noble, while the Dockerfiles (compose) are noble-chiseled. Pick one on purpose and document why.
The tenant-provisioning wait helper in integration tests returns early. Several tenant-isolation tests treat the word "Completed" anywhere in the provisioning status body as done. That matches as soon as the first step completes, before the tenant admin is seeded, which is a likely flake source. fix(identity): run session cleanup inside each tenant's context #1406 introduced a correct version that checks the overall Status field. Extract it into the shared test infrastructure and use it everywhere.
Three small hardening items that came up while reviewing #1406 and #1409. Each is small; they're grouped so they don't get lost.
src/Host/FSH.Starter.Api/Dockerfileandsrc/Host/FSH.Starter.DbMigrator/DockerfileuseFROM mcr.microsoft.com/dotnet/nightly/aspnet:10.0-noble-chiseled. That line came in with 59b513e ("bump bases off preview"), when .NET 10 was still in preview. Nightly images are unsupported and can change under you. Move tomcr.microsoft.com/dotnet/aspnet:10.0-noble-chiseled. While at it, note the drift: the csprojContainerFamily(SDK container publish, used for AWS) isnoble, while the Dockerfiles (compose) arenoble-chiseled. Pick one on purpose and document why.appsettings.Production.jsonmail keys are nested at the wrong level.Host/Port/UserName/Passwordsit directly underMailOptionsinstead ofMailOptions:Smtp, so they bind to nothing (reported in fix(deploy): working e-mail in the compose stack (Mailpit + MailOptions:Smtp:Security) and no GSS load noise #1409).Statusfield. Extract it into the shared test infrastructure and use it everywhere.