docs(#1128): document bundled-script architecture in AGENTS.md - #1129
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#1128): document bundled-script architecture in AGENTS.md#1129fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add section 9 covering the bundled-script build system and cross-context function contracts. Documents how lib files are inlined into executables via make script-build, the forge_* vs tracker_* naming split between agent types, and the verification steps required when modifying a shared lib file to ensure the called function resolves in every bundled context. This prevents cross-context breakage like PR #1124, where labels.lib.sh called forge_create_label() which was undefined in triage bundled scripts that use the tracker_* prefix. Closes #1128
|
🤖 Finished Review · ✅ Success · Started 9:59 PM UTC · Completed 10:14 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.19 |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only additive PR by a bot appending 57 lines to AGENTS.md, a protected path with elevated churn (12 commits/30d, 4 authors/90d) and frequent fix-related commits in its history; low inherent change risk is moderately offset by the file's hotspot characteristics. |
ReviewFindingsMedium
|
fullsend-ai-review
Bot
added
the
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds section 9 ("Bundled script architecture") to AGENTS.md, documenting:
scripts/lib/*.lib.shfiles are shared libraries inlined into standalone executables byscripts/bundle-sh.sh. Eachscripts/*.src.shis a source template compiled viamake script-build.forge_*prefix; triage ops usetracker_*prefix withforge_*aliases for cross-context compatibility..src.shconsumers and verify the called function is defined in every bundled context's dependency chain.make script-buildthenmake script-testafter lib file changes.This gives the code agent the architectural context it needs to avoid cross-context breakage like PR #1124, where
labels.lib.shcalledforge_create_label()which was undefined in triage bundled scripts.Testing
scripts/lib/*.lib.sh,scripts/*.src.sh) match actual repo contentsscript-build,script-test) exist in the Makefilemake lint(skillsaw) passes with no new violationsCloses #1128
Post-script verification
agent/1128-bundled-script-docs)b52686586e15571d1c4b422488ba825e2d5bf021..HEAD)