Repository navigation
pin ci to the macOS 15 image and Xcode 16.4 - #164
Merged
Merged
Conversation
The workflow on macos-latest failed before the package compiled. Keep one job that selects Xcode 16.4 and the iPhone 16 simulator on iOS 18.5. Inline the current Swift and Xcode ignore files, and describe releases from CHANGELOG.md instead of a podspec.
There was a problem hiding this comment.
🟢 Approval recommended
The CI configuration matches the documented runner inventory; only a minor inaccurate .env.example comment remains.
0 open findings
What changed in this PR
Pins CI to a known-compatible macOS/Xcode/simulator environment and updates related documentation.
Changes:
- Consolidates CI into
ci.yml. - Updates testing and release guidance.
- Refreshes ignore rules and changelog.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Pins and runs build, formatting, and tests. |
.github/workflows/test.yml |
Removes the duplicate workflow. |
.gitignore |
Refreshes Swift, Xcode, macOS, and secret rules. |
README.md |
Updates requirements and testing instructions. |
CONTRIBUTING.md |
Revises release and maintenance procedures. |
CHANGELOG.md |
Records the CI and documentation changes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ciworkflow onmainfails before this package compiles. Run 25414955912 is the latest red check.macos-latestis the macOS 26 image and does not install Xcode 16.4. The other workflow, pinned to the macOS 15 image, passed on the same commit.This PR keeps that passing job as the only workflow. The README badge already points at
.github/workflows/ci.yml.macos-15, select/Applications/Xcode_16.4.app, and test withplatform=iOS Simulator,name=iPhone 16,OS=18.5. That simulator is listed for the macOS 15 runner image..github/workflows/test.yml..gitignorefrom Swift.gitignore and Global/Xcode.gitignore, with the macOS and secret rules from project-template.CHANGELOG.mdrename plus a GitHub tag. The podspec step is gone. Add a quarterly note to revisit the Xcode pin andactions/checkout@v4.Locally, with Xcode 27.0,
xcodebuild teston the iPhone 17 simulator (iOS 27.0) reported TEST SUCCEEDED, and the Example app reported BUILD SUCCEEDED. The updated Actions workflow has not run yet.Test plan
ciworkflow on this PR selects Xcode 16.4 and finishesxcodebuild teston iPhone 16 / iOS 18.5swift formatreports a clean diff forSources/andTests/