Add an analyzer for a match where an if would do - #3470
Merged
Merged
Conversation
A match is for taking a value apart. One that only asks whether a boolean is true tells the reader to expect a destructuring and then does not deliver one, so FANTOMAS-SNOBMATCH-001 asks for an if instead. The rule is held to the boolean case, where the rewrite is mechanical: the scrutinee becomes the condition and is written once. The shape next door, a constant arm and a binder holding the scrutinee under a second name, is left alone, because every instance of it in this repository is the IndexOf idiom, where an if has to call IndexOf twice or bind it above. It also stays quiet on match!, on function, on a when guard and on a conditional directive inside the match, each because the rewrite would be more than a rewrite. List.partitionWhile held the only instance and is now an if.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A match is for taking a value apart. One that only asks whether a boolean is true tells the reader to expect a destructuring and then does not deliver one, so FANTOMAS-SNOBMATCH-001 asks for an if instead.
The rule is held to the boolean case, where the rewrite is mechanical: the scrutinee becomes the condition and is written once. The shape next door, a constant arm and a binder holding the scrutinee under a second name, is left alone, because every instance of it in this repository is the IndexOf idiom, where an if has to call IndexOf twice or bind it above. It also stays quiet on match!, on function, on a when guard and on a conditional directive inside the match, each because the rewrite would be more than a rewrite.
List.partitionWhile held the only instance and is now an if.