feat(signUp) add sign up using link - #31
Open
d0qew wants to merge 10 commits into
Open
Conversation
Author
|
fyi @alex-npmn @ckost9n For some reason, I can't assign reviewers to this PR, so I'll just ping you here 🙂 I'd really appreciate your feedback whenever you get a chance. ty |
alex-npmn
reviewed
Jun 30, 2026
| set: { if !$0 { viewModel.alert = nil } }, | ||
| ), | ||
| actions: { | ||
| Button("scan_enter_error_alert_button_okay", role: .cancel) { |
Contributor
There was a problem hiding this comment.
use button init with LocalizedStringResource
alex-npmn
reviewed
Jun 30, 2026
| } | ||
| }, | ||
| message: { | ||
| Text(viewModel.alert?.message ?? String(localized: "error_base_message")) |
Contributor
There was a problem hiding this comment.
I believe its better to set error message in view model, avoiding nil coalescing here and show Text only if error message is not nil
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+83
to
+86
| Image(systemName: "qrcode.viewfinder") | ||
| .font(.system(size: 56)) | ||
| .padding(.bottom, 8) | ||
|
|
Contributor
There was a problem hiding this comment.
please extract it as private property inside view and use here, there is an example in last merged pr
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+87
to
+90
| Text("scan_enter_info_title") | ||
| .font(.title3) | ||
| .multilineTextAlignment(.center) | ||
| .padding(.horizontal, 16) |
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+93
to
+97
| Text("scan_enter_info_subtitle") | ||
| .font(.subheadline) | ||
| .foregroundStyle(.secondary) | ||
| .multilineTextAlignment(.center) | ||
| .padding(.horizontal, 16) |
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+101
to
+114
| HStack { | ||
| Image(systemName: "link") | ||
| .foregroundStyle(.secondary) | ||
|
|
||
| TextField("invite_link", text: $viewModel.inviteLinkText) | ||
| .focused($isLinkTextFieldFocused) | ||
| .font(.body) | ||
| .frame(maxWidth: .infinity) | ||
| .keyboardType(.URL) | ||
| .autocorrectionDisabled() | ||
| .autocapitalization(.none) | ||
| .onSubmit { viewModel.handleEnteredInviteLinkText() } | ||
| .overlay(alignment: .trailing) { | ||
| if viewModel.inviteLinkText.isEmpty { |
alex-npmn
reviewed
Jun 30, 2026
| .padding(.trailing, 8) | ||
| } | ||
| } | ||
| .onTapGesture { isLinkTextFieldFocused = true } |
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+131
to
+141
| Button { | ||
| viewModel.openScanner() | ||
| } label: { | ||
| Text("scan_enter_open_scanner") | ||
| .font(.headline) | ||
| .frame(maxWidth: .infinity) | ||
| .padding() | ||
| } | ||
| .keyboardShortcut(.defaultAction) | ||
| .buttonStyle(.glassProminent) | ||
| .padding(.horizontal) |
alex-npmn
reviewed
Jun 30, 2026
| matching: .images, | ||
| photoLibrary: .shared() | ||
| ) { | ||
| Text("scan_enter_open_photo_scanner") |
Contributor
There was a problem hiding this comment.
use LocalizedStringResource init
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+169
to
+170
| title: String(localized: "scan_enter_error_alert_title_default"), | ||
| message: String(localized: "scan_enter_photo_invalid_image"), |
alex-npmn
reviewed
Jun 30, 2026
Comment on lines
+19
to
+20
| let title: String | ||
| let message: String? |
Contributor
There was a problem hiding this comment.
Suggested change
| let title: String | |
| let message: String? | |
| let title: LocalizedStringResource | |
| let message: LocalizedStringResource? |
alex-npmn
reviewed
Jun 30, 2026
| ), | ||
| actions: { | ||
| Button( | ||
| LocalizedStringResource("scan_enter_error_alert_button_okay"), |
Contributor
There was a problem hiding this comment.
it has built in codegen for LocalizedStringResource,
so your code should look like this
Button(.scanEnterErrorAlertButtonOkay, role: .cancel) {
viewModel.resetState()
}
here and at all the rest of branch, please check it, at least just run claude code to fix it
Contributor
There was a problem hiding this comment.
same for texts and the most amount of swiftUI views, they have LocalizedStringResource init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
Additionally
I made a few small improvements as part of this PR:
Attachments
phone
pad