Skip to content

feat: add serialNoColumnLabel option to customize serial number column header label - #220

Merged
sokumon merged 1 commit into
frappe:masterfrom
fury0928:feat/serial-no-column
Jan 19, 2026
Merged

feat: add serialNoColumnLabel option to customize serial number column header label#220
sokumon merged 1 commit into
frappe:masterfrom
fury0928:feat/serial-no-column

Conversation

@fury0928

@fury0928 fury0928 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Related to frappe/frappe#35724

Summary

  • Add serialNoColumnLabel option to customize the serial number column header text
  • Defaults to empty string for backwards compatibility with existing implementations

Usage

var datatable = new DataTable('#table', {
    serialNoColumn: true,
    serialNoColumnLabel: 'No.',  // Custom label
    columns: [...],
    data: [...]
});

Options

| Option              | Type   | Default | Description                           |
|---------------------|--------|---------|---------------------------------------|
| serialNoColumnLabel | String | ''      | Header label for serial number column |

To fix above issue, should I add `No.` as default to this table or should we edit from frappe frontend code?

@fury0928

fury0928 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

@sokumon @iamejaaz please review this PR
Thank you

@fury0928

fury0928 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

Good morning, @sokumon @nextchamp-saqib it'd be great if you can check this update, put for fixing the issue posted

@iamejaaz

Copy link
Copy Markdown
Member

@sokumon Could you please check, when you have some time?

@iamejaaz
iamejaaz requested a review from sokumon January 19, 2026 08:56
@sokumon
sokumon merged commit 19acc71 into frappe:master Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants