Fix 7.0 mxl862xx driver in lagacy mode and add dts for SFP lan and WAN ports for R4-Pro-4E.

[wteiken]

Device tree:

• SFP LAN and 2nd 1gbe port are enabled in the 4e dts.
• Overlays for SFP WAN and 2g5 WAN

mxl862xx drive:

• Remove pcs_inband_caps for legacy mx872xx driver.
  • The caps prevent in band setup with the legacy PCS drivers.
  • Without pcs_inband_caps supported in pcs_ops the phylink stack will not block setting up inband signaling.

[wteiken]

The mxl driver change only impacts the "legacy" (pre 1.0.80 firmware) part of the new drivers. This matches the "downstream" drivers that also do not provide the inband_caps function.

For the XPCS driver there is another inband_caps functions, that returns different inband caps for the interface types. It might be better to copy them, but I am not sure if that specific set matches the legacy firmware. So it seemed better to just disable it and have the phylink driver try (and potentially fail) the setup.

Do you have have any idea where to get the upgraded firmware (1.0.80+) the driver is referencing?

[frank-w]

This is the mainline driver,not downstream

Afaik the settings of port 13 will not yet be applied...the port stays in the firmware mode. That is one of the issues with 1.0.70 firmware...linux cannot change this mode.

Only daniel gets newer firmware under NDA,so he cannot make it public. We have to wait

[wteiken]

Yes, the reference to downstream was only about the downstream drivere also not having inband_caps.

Both wan overlays are tested against 7.0-main, so are lan6 and lan7. I'm getting 7+ gbit with iperf3 through the lan sfp (lan7). When using vlans over the lan sfp the outboundte performance breaks down (1gbit-3.5 gbit, have not yet figure out what exactly drives the variation there). Receive performance stays in the 7+ gbit range.

So it seems port 13 works just fine for me (with the 1.0.70 firmware). With the driver change it may also work for the 8x given that that mainly adds the extra mux. The only issue there seemed to be that PCS was not properly initialized.

I assume this will also work in 7.1-rc1, hope I will get that booting to test.