Repository navigation
Raw C apps check CFE_MSG return codes; pin fprime_cfs/fprime_app review-nit branches - #45
Open
lestarch-autobot wants to merge 1 commit into
Open
lestarch-autobot wants to merge 1 commit into
lestarch-autobot wants to merge 1 commit into
Conversation
…ew-nit branches - raw_commander / raw_commanded: every CFE_MSG_GetMsgId / GetSize / GetFcnCode / ValidateChecksum return code is checked; a failure is reported with a new RAW_COMMANDER_MSG_ERR_EID / RAW_COMMANDED_MSG_ERR_EID event and the message is dropped (counted as rejected on the commanded side) - libs/fprime_cfs -> 38b039e (shared CfsChecksum, CfsRouter malformed-packet fuzz UT, cfsDataIn allocation-failure UT) - apps/fprime_app -> 6a1f56d (ComCfg.EchoFunctionCode single source; EchoCommander UT compile fix) Co-authored-by: M Starch <LeStarch@googlemail.com>
lestarch-autobot
force-pushed
the
devin/1793850000-cfs-nits
branch
from
November 6, 2026 23:17
79477db to
1284757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Residual review nits from #41, plus the pins for the matching library/app nit PRs:
raw_commander/raw_commanded: everyCFE_MSG_GetMsgId/GetSize/GetFcnCode/ValidateChecksumreturn code is now checked. A failure raises a newRAW_COMMANDER_MSG_ERR_EID/RAW_COMMANDED_MSG_ERR_EIDerror event and the message is dropped (counted as rejected on the commanded side) instead of being acted on with default-initialized values.libs/fprime_cfs→ Share the cFS command checksum, fuzz CfsRouter with malformed packets, cover cfsDataIn allocation failure fprime_cfs#34 (sharedCfsChecksum,CfsRoutermalformed-packet fuzz UT,cfsDataInallocation-failure UT)apps/fprime_app→ Single-source the echo function code; fix EchoCommander UT call missing the APID fprime_app#25 (ComCfg.EchoFunctionCodesingle source for the route table and the Echo components; EchoCommander UT compile fix)Gitlinks point at the
lestarch-autobotfork commits until #34 and #25 merge; re-pin to the upstream SHAs before merging (same order as #41 → #42, #43).2026-11-06 rebase: rebased onto
develafter #44 (ci_lab/to_lab GDS path). The fprime_cfs#34 branch was itself rebased onto fprime_cfsdevelso thelibs/fprime_cfsgitlink (bb8675b) carries both #33 (cfs-lab/cfs GDS plugins) and the #34 nits;apps/fprime_appstays at the #25 head (6a1f56d, one commit ahead of devel). The two original commits collapsed into one.Testing
Clean
make -j8 && make install; livecore-cpu1withfprime-gds --ip-client --ip-port 15010through the GdsBridge app (pre-#44; the post-rebase run goes through--communication-selection cfs-lab --framing-selection cfsin CI): raw_commander ↔ EchoResponder and EchoCommander ↔ raw_commanded matched every cycle, no mismatch/timeout/checksum events;pytest test/int9/9. Library UTs: CfsRouter 18/18 (incl. 5000-packet fuzz), CfsCmdFramer 5/5, CfsAppBridge 7/7, CfsBridge 30/30; EchoResponder 5/5, EchoCommander 7/7 from a clean UT build.AI Used: y — developed with Devin (lestarch-autobot), directed by M Starch.
Written by Devin