Repository navigation
Document SCH tick prerequisite for rate groups in README - #12
Closed
lestarch-autobot wants to merge 1 commit into
Closed
lestarch-autobot wants to merge 1 commit into
lestarch-autobot wants to merge 1 commit into
Conversation
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Addresses the documentation must-fix from the multi-agent review of #11: the README's "Running the Reference" section did not mention that the F Prime application's rate groups depend on cFS SCH tick messages (APID 0x0090), which no app in the repo currently publishes. Adds an IMPORTANT callout documenting the SCH prerequisite and pointing to #9, which adds the SCH app.
The remaining must-fixes from the review (no tick source in the repo; devel integration tests failing) are resolved by merging #9, not by changes in this PR.
Testing performed
Documentation-only change; no build required.
Expected behavior changes
No impact to behavior.
System(s) tested on
N/A (documentation only)
Additional context
Follow-up to the multi-agent review of #11.
Contributor Info
Michael Starch, NASA JPL (via Devin)