Repository navigation
Drop the FPP JSON model and adopt the FprimePython CMake hook - #8
Merged
LeStarch merged 4 commits intoNov 10, 2026
Conversation
…ent running - Remove FPRIME_ENABLE_JSON_MODEL_GENERATION and fprime-python-model: fprime-python reads FPP directly. - Replace the pybind11 and target registration block with include(FprimePython); the build now links the deployment to pybind11::embed. - README: start the GDS and the Python flight software separately; the deployment README no longer describes a C++ binary. - Update lib/fprime-python. Co-authored-by: M Starch <LeStarch@googlemail.com>
Co-authored-by: M Starch <LeStarch@googlemail.com>
Co-authored-by: M Starch <LeStarch@googlemail.com>
3 tasks done
LeStarch
approved these changes
Nov 10, 2026
fprime-community/fprime-python#17 was squash-merged; the tree is identical to the commit pinned before. Co-authored-by: M Starch <LeStarch@googlemail.com>
LeStarch
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Brings the reference in line with the native FPP bindings and with fprime-community/fprime-python#17 (merged).
FPRIME_ENABLE_JSON_MODEL_GENERATIONand thefprime-python-modelrequirement:fprime-pythonreads the FPP model directly and no longer needs thefpp-to-jsonexport.register_fprime_targetblock withinclude(FprimePython), and drops the deployment's ownpybind11::embedlink; the tool now does both.lib/fprime-pythonsubmodule to0a8a0c3, the merge of Build fprime_py for the Python deployment only, install Python files on every build, and add a CMake hook and component cookiecutter fprime-python#17 onmain.Testing/Review Recommendations
Built from a clean build directory; GDS integration tests (
pytest test/int): 4 passed, and again with the submodule at the merged commit. Linux x86_64 only.AI Usage
Generative AI was used in this contribution: AI. Changes were written by Devin (AI agent) at the direction of @LeStarch.
IAMAI