feat: added remote syslog logging and log annotation (domain+msgid)#850
Open
terminar wants to merge 1 commit into
Open
feat: added remote syslog logging and log annotation (domain+msgid)#850terminar wants to merge 1 commit into
terminar wants to merge 1 commit into
Conversation
foxcpp
reviewed
May 23, 2026
| // LogFields are rendered as [key=value ...] before the message text so | ||
| // that individual mail flows can be identified and filtered with grep. | ||
| // Use With() to populate this. | ||
| LogFields []string |
Owner
There was a problem hiding this comment.
I'm not sure if this is a good solution since we already have Fields.
This is probably better done by customizing formatting at Logger level - msg_id is already added explicitly for most log records that are related to message delivery.
This, in turn, would require some further design work as current logger implementation is very simple and lacks extended configuration parsing.
Is there a specific reason why need fields formatted in this exact way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
Explanation:
I use Maddy in some sort of shared environment and I needed to separate log access to specific domains.
This PR combined with a filtering/routing syslog daemon (another project) fits the need.
I am not sure if this is interesting in any case but I wanted to share and give back code so here it is.