Skip to content

cli: mesh BRep shapes when exporting to image — closes #412 #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calumk wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

cli: mesh BRep shapes when exporting to image — closes #412 #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cli/cli_export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,14 @@ bool importInDocument(DocumentPtr doc, const CliExportArgs& args, Helper* helper
{
auto appModule = AppModule::get();

// If export operation targets some mesh format then force meshing of imported BRep shapes
// If export operation targets some mesh format then force meshing of imported BRep shapes.
// Image export also requires a mesh: GraphicsShapeObjectDriver disables auto-triangulation, so
// without an explicit mesh the BRep shapes have no triangulation to shade and are rendered as
// wireframe only.
bool brepMeshRequired = false;
for (const FilePath& filepath : args.filesToExport) {
const IO::Format format = appModule->ioSystem()->probeFormat(filepath);
brepMeshRequired = IO::formatProvidesMesh(format);
brepMeshRequired = IO::formatProvidesMesh(format) || format == IO::Format_Image;
if (brepMeshRequired)
break; // Interrupt
}
Expand Down
Loading