Skip to content

Write log files with utf-8 encoding - #309

Merged
soimkim merged 1 commit into
mainfrom
gradle
Aug 30, 2026
Merged

soimkim merged 1 commit into
mainfrom
gradle

Conversation

@soimkim

@soimkim soimkim commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Windows FileHandler defaulted to cp949 and failed on non-cp949 characters in debug logs. Open log files as UTF-8 instead.

Windows FileHandler defaulted to cp949 and failed on non-cp949
characters in debug logs. Open log files as UTF-8 instead.
@soimkim
soimkim requested a review from bjk7119 August 30, 2026 23:24
@soimkim soimkim self-assigned this Aug 30, 2026
@soimkim soimkim added the bug fix [PR] Fix the bug label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1332aa8b-2d1e-4c3c-a6ec-8873ad4cafd8

📥 Commits

Reviewing files that changed from the base of the PR and between 225c447 and 8d92c62.

📒 Files selected for processing (1)
  • src/fosslight_util/set_log.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The logging setup now uses explicit UTF-8 encoding for the initial, relocated, and fallback log file handlers.

Changes

Logging Encoding

Layer / File(s) Summary
Set UTF-8 encoding for log handlers
src/fosslight_util/set_log.py
The initial, relocated, and fallback FileHandler instances now use encoding="utf-8".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8d92c

This localized change updates log-file encoding behavior to support UTF-8, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: bjk7119

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: writing log files with UTF-8 encoding.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gradle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim
soimkim merged commit 0ff66b2 into main Aug 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant