Repository navigation
fix(payments): block installation alongside Ledger v3 - #552
Merged
Merged
Conversation
NumaryBot
added
risk: high
bot-reviewed
review-approved
NumaryBot
approved these changes
Oct 9, 2026
NumaryBot
left a comment
NumaryBot
left a comment
Contributor
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payments cannot run alongside Ledger v3. The Operator now rejects that combination using the effective Ledger version, including prereleases, while continuing to support Payments in stacks without a Ledger.
Payments also blocks Ledger v2-to-v3 materialization until the module is removed. If a primary v3 Cluster already exists, its owned runtime and API resources are cleaned up while persistent data is retained. Ledger and Versions changes automatically reevaluate compatibility.
Validation:
go test ./...passed with envtest on the current main base. Added coverage for optional Ledger presence, effective-version/catalog changes, installation refusal, transition protection, and runtime cleanup. Structured autoreview reported no actionable findings.