Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ledger's fctl commands need an independently installable executable now that fctl no longer owns the product implementation. This PR brings the existing product-owned plugin to
release/v3.0undermisc/fctl-plugin, preserving the command/form contract, payload validation, page cursors, exact JSON integers, partial bulk results and business errors.Following Auth #162,
fctl-plugin-ledgeruses only the publicgithub.com/formancehq/fctl/pkg/pluginsdkboundary andtransport.Serve. Offline--manifestand--versionreport the exact co-released service version and a separate plugin revision. GoReleaser packages Linux/macOS/Windows for amd64/arm64.Tagged release CI preflights all six executable identities before upload, publishes raw OCI executable layers to
ghcr.io/formancehq/fctl-plugin-ledger, and attachesfctl-plugin-catalogue.jsongenerated from the native manifest, actual binary checksums and immutable OCI digests. Publication uses the job token, with isolated registry credentials. Nightly jobs do not perform catalogue publication.Validation:
bash scripts/agent-checkandAI_REVIEW_BASE_SHA=8e9bb3ebc13f9235fa20e92fb45018a6f7e91e16 bash scripts/agent-check-pr: PASS. The selector ran full Nix/Just normalization, baseline and complete root-module race tests. No generated drift remains.c07b2b5reference) plus actual Ledger plugin against controlled local APIs: install/show, execute, exact integer request/result, partial bulk error, exact-version drift refusal before mutation, offline help and completion.First-publication follow-up: review/merge this Draft through normal gates, choose a service tag containing the changes, make the GHCR package Public after first upload, verify anonymous downloads/checksums, then separately promote the six release entries into
formancehq/fctl-plugin-registry. The README includes commands and failure/retry behavior. Hosted GHCR permissions and first-release upload remain to be verified by that publication.No fctl changes, tag creation, release trigger or merge performed.