Repository navigation
feat(auth): provide a product-owned fctl plugin #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4a9adbc
feat(fctl-plugin): extract standalone Auth command module
flemzord a61be6d
test(fctl-plugin): verify Auth public API and executable contract
flemzord 94f7c95
build(auth): package versioned fctl plugins with product releases
flemzord add6bd4
ci(auth): publish fctl plugins to GHCR on tagged releases
flemzord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,5 @@ vendor | |
| .idea | ||
| coverage.* | ||
| auth | ||
|
|
||
| /build/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # yaml-language-server: $schema=https://goreleaser.com/static/schema.json | ||
| version: 2 | ||
| project_name: fctl-plugin-auth | ||
| dist: build/fctl-plugin | ||
|
|
||
| env: | ||
| - PLUGIN_REVISION={{ envOrDefault "PLUGIN_REVISION" "1" }} | ||
| - AUTH_SERVICE_VERSION={{ envOrDefault "AUTH_SERVICE_VERSION" .Version }} | ||
|
|
||
| builds: | ||
| - id: fctl-plugin-auth | ||
| binary: fctl-plugin-auth | ||
| dir: misc/fctl-plugin | ||
| main: ./cmd/fctl-plugin-auth | ||
| env: | ||
| - CGO_ENABLED=0 | ||
| ldflags: | ||
| - -s -w | ||
| - -X main.serviceVersion={{ .Env.AUTH_SERVICE_VERSION }} | ||
| - -X main.revision={{ .Env.PLUGIN_REVISION }} | ||
| goos: | ||
| - linux | ||
| - darwin | ||
| - windows | ||
| goarch: | ||
| - amd64 | ||
| - arm64 | ||
|
|
||
| archives: | ||
| - ids: | ||
| - fctl-plugin-auth | ||
| name_template: "{{ .ProjectName }}_v{{ .Env.AUTH_SERVICE_VERSION }}_r{{ .Env.PLUGIN_REVISION }}_{{ .Os }}-{{ .Arch }}" | ||
| formats: | ||
| - tar.gz | ||
| format_overrides: | ||
| - goos: windows | ||
| formats: | ||
| - zip | ||
| files: | ||
| - src: misc/fctl-plugin/README.md | ||
| dst: README.md | ||
|
|
||
| checksum: | ||
| name_template: checksums.txt | ||
|
|
||
| release: | ||
| disable: true | ||
| changelog: | ||
| disable: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/golangci.jsonschema.json | ||
| version: "2" | ||
|
|
||
| formatters: | ||
| enable: | ||
| - gci | ||
| - gofmt | ||
| - goimports | ||
| settings: | ||
| gci: | ||
| sections: | ||
| - standard | ||
| - default | ||
| - prefix(github.com/formancehq/) | ||
| - localmodule | ||
| custom-order: true | ||
|
|
||
| run: | ||
| timeout: 5m | ||
|
|
||
| linters: | ||
| default: none | ||
| enable: | ||
| - bodyclose | ||
| - contextcheck | ||
| - errcheck | ||
| - errorlint | ||
| - exhaustive | ||
| - gocognit | ||
| - gosec | ||
| - govet | ||
| - ineffassign | ||
| - modernize | ||
| - nilerr | ||
| - noctx | ||
| - nolintlint | ||
| - revive | ||
| - staticcheck | ||
| - unused | ||
| - usetesting | ||
| settings: | ||
| errcheck: | ||
| check-blank: true | ||
| check-type-assertions: true | ||
| disable-default-exclusions: true | ||
| exhaustive: | ||
| # A default branch must not hide a newly added enum value. | ||
| default-signifies-exhaustive: false | ||
| gocognit: | ||
| min-complexity: 15 | ||
| nolintlint: | ||
| allow-unused: false | ||
| require-explanation: true | ||
| require-specific: true | ||
| revive: | ||
| rules: | ||
| - name: blank-imports | ||
| - name: context-as-argument | ||
| - name: context-keys-type | ||
| - name: dot-imports | ||
| - name: empty-block | ||
| - name: error-naming | ||
| - name: error-return | ||
| - name: error-strings | ||
| - name: errorf | ||
| - name: increment-decrement | ||
| - name: receiver-naming | ||
| - name: time-naming | ||
| - name: unexported-return | ||
| - name: var-naming |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 [minor] Include plugin tests in the uploaded coverage reports
When
just testsruns,test-fctl-pluginexecutesgo test -race ./...without a coverage profile, while the subsequent root-module test writes onlycoverage.txt. As the README explicitly notes, root-module tests do not discover this nested module. Consequently the new plugin contributes no coverage data to the normal reporting path, so coverage regressions in it are invisible to the required coverage tracking despite its tests running.Suggestion: Generate a separate atomic coverage profile for the nested module and include it in the CI coverage upload alongside the root profile. Keep race detection enabled and avoid having the root test overwrite the plugin profile.