feat: persist .forge/ artifacts in workflow state for cross-worker continuity - #44
Closed
eshulman2 wants to merge 8 commits into
Closed
feat: persist .forge/ artifacts in workflow state for cross-worker continuity#44eshulman2 wants to merge 8 commits into
eshulman2 wants to merge 8 commits into
Conversation
3 tasks
3 tasks
…reation Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ccess Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ainers Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…after implement_review Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
eshulman2
force-pushed
the
feature/forge-artifacts
branch
from
August 6, 2026 11:59
a0aed92 to
9e36462
Compare
Collaborator
Author
|
Closing in favor of #260. The replacement keeps cross-worker continuity narrowly scoped to a typed, per-repository handoff record and avoids using workflow state as a generic .forge artifact store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forge_artifacts: dict[str, dict[str, str]]toPRIntegrationState(shared by bothFeatureStateandBugState) to persist container-written.forge/files across workspace recreations, keyed by repo name for multi-repo feature supportharvest_forge_artifacts/restore_forge_artifactsutilities insrc/forge/workspace/artifacts.py— each calling node declares which files it harvests, making the mechanism explicit and portable to future workflowsimplement_task(handoff.md),attempt_ci_fix(handoff.md+fix-plan.md), andimplement_review(review-plan.md,review-objections.md,handoff.md)setup_workspaceandprepare_workspace(recreation path only) so containers always start with prior artifacts on diskBug Workflow Coverage
The bug workflow's RCA and planning stages (
analyze_bug,reflect_rca,plan_bug_fix) use ephemeral temp directories and parse outputs inline into state — no.forge/artifacts need to persist across those runs. The implementation stage reuses the shared nodes (setup_workspace,implement_task,implement_review,attempt_ci_fix) that already have harvest/restore wired in.BugStateinheritsforge_artifactsfromPRIntegrationStateand initializes it to{}. No additional changes needed.Updated
WorkspaceManager.destroy_workspacefix previously included here (podman unshare rm -rffor root-owned cleanup) was dropped — an equivalent fix already landed on main via fix: remove workspaces containing root-owned container files #141, and main's version is a superset (addsOSErrorfallback handling)._recreate_workspace_from_forkon main restructured workspace recreation into an atomic build-beside-then-swap;restore_forge_artifactsis now wired in after the swap completes, alongsidewrite_workspace_identity.Test plan
handoff.mdis harvested afterimplement_taskand restored on workspace recreationfix-plan.md+handoff.mdare harvested and available on retryimplement_reviewcycle — verifyreview-plan.md,review-objections.md,handoff.mdare persisted🤖 Generated with Claude Code