Skip to content

Honor container settings in task takeover - #279

Merged
eshulman2 merged 1 commit into
mainfrom
fix/task-takeover-container-settings
Aug 7, 2026
Merged

Honor container settings in task takeover#279
eshulman2 merged 1 commit into
mainfrom
fix/task-takeover-container-settings

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • stop constructing a hard-coded default ContainerConfig in task-takeover execution
  • apply the same fix to task-takeover qualitative review
  • let ContainerRunner derive timeout, image, memory, and CPU limits from application settings
  • add regression assertions that these workflows do not override runner defaults

Root cause

Both task-takeover call sites passed ContainerConfig(), whose timeout defaults to 1800 seconds. Because a config object was supplied, ContainerRunner.run() never called its settings-backed _default_config(), so CONTAINER_TIMEOUT=7200 was ignored and Podman received --timeout 1800.

Testing

  • Ruff passed for all four changed files
  • Focused unit suite: 23 passed

@eshulman2
eshulman2 merged commit 20643c3 into main Aug 7, 2026
6 checks passed
@eshulman2
eshulman2 deleted the fix/task-takeover-container-settings branch August 7, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant