Harden workspace backup cleanup - #278
Open
eshulman2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOTEMPTYfailures while removing a replaced workspace backupContext
AISOS-2385 recovered a dirty workspace by swapping in a fresh clone, but deletion of the renamed old workspace raced with filesystem activity and raised
[Errno 39] Directory not empty. That secondary cleanup exception then became the reported task failure even though the replacement workspace was already installed.Testing
uv run ruff check src/forge/workflow/nodes/workspace_setup.py tests/unit/workflow/nodes/test_workspace_setup.pyuv run pytest tests/unit/workflow/nodes/test_workspace_setup.py(14 passed)