Skip to content

Add a fail-closed safe-output gate - #269

Closed
eshulman2 wants to merge 2 commits into
mainfrom
issue-263-safe-outputs
Closed

Add a fail-closed safe-output gate#269
eshulman2 wants to merge 2 commits into
mainfrom
issue-263-safe-outputs

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • add a centralized fail-closed validation boundary to both Git push paths
  • reject protected paths, unsafe symlinks, oversized output, malformed Git metadata, and missing trusted base references
  • support global and repository-oriented protected path rules
  • add an OutputValidator extension interface for secret scanning and future validation controls
  • document output-gate configuration

Security model

Validation compares changes against the trusted origin/HEAD merge base and executes before external push. Invalid policy or validation errors fail closed.

Test plan

  • 16 focused output-validation and Git operations tests pass
  • Python compilation succeeds
  • git diff --check passes
  • Run Ruff in CI (the isolated implementation clone could not download a missing dependency because network DNS was unavailable)

Closes #263

Related: #77, #150, #174

@eshulman2

Copy link
Copy Markdown
Collaborator Author

Closing to refine the implementation as a repository-change validation boundary in GitOperations, with typed results and a clean validator composition point for #77, before reopening.

@eshulman2 eshulman2 closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a fail-closed pre-push validation gate in GitOperations

1 participant