Skip to content

Block secret externalization from Forge workflows - #267

Closed
eshulman2 wants to merge 2 commits into
mainfrom
issue-77-secret-scan
Closed

Block secret externalization from Forge workflows#267
eshulman2 wants to merge 2 commits into
mainfrom
issue-77-secret-scan

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • add fail-closed secret detection before every Git push
  • scan committed, staged, unstaged, and relevant untracked changes against the trusted origin
  • scan GitHub PR/comment and Jira comment content before HTTP publication
  • support trusted-base .secrets.baseline allowlists
  • redact findings so matched values never enter logs or blocked-state messages
  • block on timeouts, scanner errors, unsafe symlinks, and invalid baselines

Test plan

  • 75 focused tests pass
  • relevant GitHub/Jira compatibility tests pass
  • Ruff passes
  • coverage includes provider keys, generic tokens, clean text, baselines, binary and untracked files, symlinks, timeouts, and redaction

Integration note

#263 introduces the preferred common OutputValidator boundary. If it merges first, this PR should be rebased and its Git-push scanner adapted to that interface so Forge has one composed pre-push security gate rather than duplicate hooks. GitHub/Jira text-publication scanning remains specific to this PR.

Closes #77

Related: #263

@eshulman2

Copy link
Copy Markdown
Collaborator Author

Closing to rework the implementation around Forge's provenance boundaries: secret scanning will compose into #263's pre-push validator and workflow nodes will explicitly scan agent-derived text instead of globally intercepting Jira/GitHub clients.

@eshulman2 eshulman2 closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan agent-derived code and text for secrets before publication

1 participant