NEW @W-23442992@ [Bug Bounty / H1]Salesforce Code Analyzer custom_engine_plugin_modules hidden config key#2066
Conversation
aruntyagiTutu
left a comment
There was a problem hiding this comment.
APPROVED — correctly stops the CLI from invoking the vulnerable dynamic-plugin-loading API, closing this repo's side of the RCE (companion to code-analyzer-core#483).
Review Against Guidelines ✅
5. Architecture ✅ — Removes all three call sites (ConfigAction, RulesAction, RunAction) that fed custom_engine_plugin_modules into core.dynamicallyAddEnginePlugin. Also cleans up the now-obsolete TODO comments that referenced the removed hidden feature.
Correctness ✅ — Since this only deletes calls to core APIs rather than depending on their removal, it compiles and functions correctly even before code-analyzer-core bumps its version to include #483 — a safe, independently-deployable mitigation.
8. PR Hygiene
13. Dependency Management — Note for follow-up: once code-analyzer-core#483 merges and releases, this repo's @salesforce/code-analyzer-core dependency (currently 0.49.0) should be bumped so the hidden config key/method are fully removed end-to-end rather than just unused.
No description provided.