Repository navigation
[Package] Hybrid+iOS app generation has no override path for the SalesforceMobileSDK-iOS SDK dependency (--sdkdependencies is a no-op for hybrid Podfile) - #346
Merged
JohnsonEricAtSalesforce merged 2 commits intoAug 25, 2026
Merged
Conversation
The iOS SDK dependency for hybrid apps comes from a Podfile generated by the Cordova plugin, hardcoded to the dev branch. overrideSdkDependencies() only ever patched package.json, which that Podfile has no influence from, so --sdkdependencies was a silent no-op for hybrid+iOS. Rewrite the :git/:branch of any pod sourced from a repo named in the override, right after `cordova plugin add` creates the Podfile and before `cordova prepare` reparses/reinstalls it.
wmathurin
reviewed
Aug 24, 2026
…n instead of silently skipping when a matching pod isn't pinned with :branch)
wmathurin
approved these changes
Aug 25, 2026
JohnsonEricAtSalesforce
merged commit Aug 25, 2026
752436e
into
forcedotcom:dev
13 of 17 checks passed
JohnsonEricAtSalesforce
deleted the
bugfix/package-hybrid-ios-sdkdependencies-podfile-no-op
branch
August 25, 2026 00:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sdkdependencieshad no effect for hybrid+iOS app generation. ThePodfileproduced by theCordova plugin (
SalesforceHybridSDK,MobileSync,SalesforceAnalytics,SalesforceSDKCommon,SalesforceSDKCore,SmartStore) stays hardcoded to:branch => 'dev'againstSalesforceMobileSDK-iOS, regardless of the override. The existingoverrideSdkDependencies()only patches
package.json'ssdkDependenciesblock, which the hybrid+iOS Podfile-based podinstall never reads.
Fix: a new
overrideHybridIosPodfile()rewrites the Podfile's pod lines to point at theoverridden git URL/branch. It runs right after
cordova plugin add(which already ranpod installonce against the plugin's hardcoded pod sources) and beforecordova prepare, whichunconditionally reparses and rewrites the Podfile and reruns
pod installa second time (theplugin sets a deployment-target preference) — that second install is what actually picks up the
edit.
Test plan
overrideHybridIosPodfile(full rewrite of affected pods,default-to-
dev-branch when the override omits a branch, non-matching repo left untouched,missing-Podfile error path) — full suite passing (38/38)
--sdkdependenciespointed at a real compatible SDK fork/branch — confirmed the Podfile override is applied and
survives
cordova prepare'spod installre-runThis response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce.