Repository navigation
CI: build free package safely for fork PRs - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prosubmoduleprois missingconversioncolumn so the packaged plugin activates on current MariaDBSecurity boundary
This PR does not use
pull_request_target, check out the private submodule, or expose private credentials to fork-controlled code. Free-mode coverage injects a synthetic private sentinel and verifies it is absent from both the generated translation catalog and ZIP archive.Root cause
The public workflow checked out no submodules but ran the full package command, whose webpack, assets, localization, Composer, and ZIP stages expected
pro. Both the PR branch and unchangedmasterreproduced the same missing-Pro failure.Verification
TDD / local
npm run test:ci-packageon Node 18.20.8: 3/3 passedpro/entries and no synthetic private sentinelnpm run test:php: passednpm run test:js: 20 files / 88 tests passed on supported Node 22git diff --check: passedGitHub Actions
Authoritative run: https://github.com/fooplugins/fooconvert/actions/runs/31719483906
Scope
No versions, compatibility metadata, release artifacts, tags, deployments, production systems, private credentials, or WordPress.org SVN records were changed.
Notes
setAccessible()deprecation notices remain non-blocking and were not introduced here.