feat: add response controller middleware - #304
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ResponseControllerandMaxRequestBodySizeHTTP middlewares, and raise the serverIdleTimeoutto 620s.Type of Change
Changes
middleware.ResponseController(h)— runshagainst the request'shttp.ResponseControllerbefore the handler, so read/write deadlines, full duplex and flush can be overridden per connection (e.g. clearing the write deadline for SSE). An error fromhis logged and the handler still runs.middleware.MaxRequestBodySize(n)— rejects a declaredContent-Lengthovernwith 413 before the handler runs, and wraps the body inhttp.MaxBytesReaderso chunked or lying clients fail on read with*http.MaxBytesError.net/http/server.go—IdleTimeout120s → 620s so the peer is always the side closing an idle connection; comment documents the managed-L7 values it clears (GCLB 600s, Azure App Gateway 240/300s, ingress-nginx 60s, ALB 60s) and the Envoy-sidecar caveat.Checklist