fix(telemetry): err nil check & bump deps - #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework the telemetry span helpers to operate on
trace.Spaninstead ofcontext.Context, fixDeferEndSpanto dereference the error pointer at defer-run time, and bump dependencies across all modules.Type of Change
Changes
AddSpanEvent,SetSpanAttributes,SetSpanName,IsSpanRecording,SetSpanDebug,SetSpanStatusOK,SetSpanStatusError,EndSpan,DeferEndSpan) now take atrace.Spaninstead of acontext.ContextContext.WithCancel,WithCancelCause,WithDeadline,WithTimeout,WithValueandWithoutCancelnow returntelemetry.Contextinstead ofcontext.Context, so the fluent API chainsDeferEndSpanto passoptsthrough toEndSpanand to tolerate anilerror pointer instead of panickingstartSpanasInternalStartSpanfor use by other telemetry packages; it now returns a plaincontext.ContextAddSpanLinkon both the package andContextIsRecording()guard fromContext.RecordError/RecordSpanError— the SDK already no-ops on non-recording spansEndno longer setscodes.Okon success;EndSpanleaves the statusUnsettelemetry/span_test.gocovering theEndSpanvsDeferEndSpandeferred-error semanticsmake outdated/make upgradenow usego-mod-upgrade; pinnedgoreleaser,go-mod-upgradeandgovulncheckin.mise.tomlinstead ofgo install-ing govulncheck on every runChecklist
Notes
This is a source-breaking change for any consumer calling the span helpers with a context; migration is mechanical (
telemetry.SetSpanName(ctx, n)→telemetry.SetSpanName(telemetry.SpanFromContext(ctx), n)).