feat: configurable service name - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
serviceNamestarget option to override the display name used for OTel spans and metrics per service.Type of Change
Changes
serviceNames map[string]stringtoconfig.Targetplus aTarget.ServiceName(service)helper that falls back to the service name when no override is set (does not affect generated Go types or routing).config.ServiceName(...)intorenderTSRPCServiceProxies,renderTSRPCServiceClients,renderGoRPCServiceProxies, andrenderGoRPCServiceClientsso the telemetry name flows intoNewServer/WithClientService.gotsrpc.schema.jsonandgotsrpc.example.yamlwith the newserviceNamesproperty; document it indocs/guide/configuration.md.updateCodeinbuild.go: propagate theos.ReadFileerror instead of ignoring it, tightenMkdirAllperms to0700, and drop the//nolint:gosecsuppressions.semconv.Configfield docs for the client-sidePackage/Serviceusage.monitorexample withserviceNames: { Service: Monitor }.Checklist