fix(golden): support Stado sandboxing on Ubuntu - #5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Devbox golden image provisioning and verification to support Stado’s Linux sandboxing on Ubuntu (notably Ubuntu 24.04’s AppArmor user-namespace restrictions) by ensuring required sandbox helper tools are present and by enabling a scoped AppArmor profile for bwrap.
Changes:
- Install sandbox prerequisites in goldens (
bubblewrap/bwrapandpasst/pasta), plus Ubuntu AppArmor packages for the restrictedbwrapprofile. - Add an Ubuntu 24.04-specific provisioning step to load AppArmor’s
bwrap-userns-restrictprofile without disabling the global user-namespace restriction. - Extend golden verification and Bats tests to assert presence/usability of
bwrapandpasta --splice-only.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/devbox |
Adds packages to golden provisioning, loads Ubuntu’s restricted bwrap AppArmor profile, and extends golden verification to exercise bwrap/pasta. |
test/devbox.bats |
Adds tests to assert the golden YAML and verification logic include the new sandbox prerequisites and Ubuntu AppArmor policy behavior. |
README.md |
Documents the new golden sandbox helpers and the Ubuntu 24.04 AppArmor behavior/intent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bwrapandpasta) to every goldenpasta --splice-onlyin new goldensValidation
bash -n bin/devboxmake test(82 Bats + 33 Python tests)make lintgit diff --checknode --check docs/assets/site.jsNo existing Devbox instance was started or restarted.