docs(site): configure Pages custom domain - #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Configures the GitHub Pages site to use a Pages-managed custom domain and adds a regression test to ensure the published site source includes the expected custom-domain configuration.
Changes:
- Add
docs/CNAMEfor the Pages custom domaindevbox.foobarto.me. - Extend the static-site structural test to assert the expected
CNAMEcontents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/site_test.py |
Adds an assertion that the published Pages source includes the expected CNAME content. |
docs/CNAME |
Introduces the Pages-managed custom domain file for devbox.foobarto.me. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
97
to
+99
| self.assertTrue((SITE / ".nojekyll").is_file()) | ||
| self.assertTrue((SITE / "index.html").is_file()) | ||
| self.assertEqual("devbox.foobarto.me\n", (SITE / "CNAME").read_text(encoding="utf-8")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add the Pages-managed
docs/CNAMEfordevbox.foobarto.me\n- assert the published-source custom-domain file in the static-site test\n\n## Verification\n-make test\n-make lint\n-node --check docs/assets/site.js\n- staged Gitleaks scan