Skip to content

fix: resolve pre-existing CI failures - #159

Open
AlexV525 wants to merge 1 commit into
mainfrom
fix/ci-preexisting-failures
Open

fix: resolve pre-existing CI failures#159
AlexV525 wants to merge 1 commit into
mainfrom
fix/ci-preexisting-failures

Conversation

@AlexV525

Copy link
Copy Markdown
Member

Summary

Fixes all pre-existing CI failures that were independent of the SPM migration (#158).

Root causes & fixes

1. flutter analyze deprecation warnings → error

The example used deprecated Flutter / package APIs that newer stable Flutter flags as info, causing flutter analyze to exit non-zero.

Deprecated Replacement
Color.withOpacity(x) Color.withValues(alpha: x)
ImageSizeGetter.getSize() ImageSizeGetter.getSizeResult().size
ShowValueIndicator.always ShowValueIndicator.onDrag

Also bumped image_size_getter: ^2.1.2 → ^2.4.0 to get the getSizeResult API.

2. Ancient Flutter version matrix → runner incompatibility

try-add-to-new-project.yml tested against Flutter 3.0.5 / 3.7.0 / 3.10.6, which:

  • Generate Podfiles using File.exists? (removed in Ruby 3.4 on current runners)
  • Target Visual Studio 2019 (not installed on current windows-latest)

Fix: Rewrote to use stable only, one job per platform (matching flutter_photo_manager pattern).

3. runnable.sh fragility

The shell activated dart pub global run dartdoc (slow, version-sensitive). Replaced runnable.yml with inline workflow steps: per-package flutter analyze, dart doc --dry-run.

Verification

cd image_editor/example && flutter analyze lib
→ No issues found! (ran in 2.0s)

Concurrency

Both workflows now use concurrency: cancel-in-progress: true to auto-cancel stale runs.

Reference

CI patterns adopted from flutter_photo_manager (runnable.yml, check-compatibility.yml).

@AlexV525
AlexV525 force-pushed the fix/ci-preexisting-failures branch 7 times, most recently from 20fe5c3 to 65eaa51 Compare August 13, 2026 15:03
Example deprecation warnings (flutter analyze):
- Replace withOpacity() with withValues(alpha:)
- Replace getSize() with getSizeResult().size
- Replace ShowValueIndicator.always with .onDrag
- Bump image_size_getter to ^2.4.0 for getSizeResult API

Workflow modernization (reference flutter_photo_manager):
- runnable.yml: inline steps instead of runnable.sh, use dart doc
  --dry-run, add concurrency, analyze each package directly
- try-add-to-new-project.yml: replace ancient Flutter 3.0.5/3.7.0/3.10.6
  matrix with stable-only, one job per platform
@AlexV525
AlexV525 force-pushed the fix/ci-preexisting-failures branch from 65eaa51 to b61bda5 Compare August 13, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant