Repository navigation
docs(filter/parser): fix swapped reserve_time examples - #711
Merged
Merged
Conversation
When reserve_time is true, Fluentd keeps the original event time and discards the parsed time; when false (default), the parsed time is used. The examples previously showed the opposite. Matches filter_parser.rb. Fixes fluent#439 Signed-off-by: Satvik Mishra <Satvikmishra.ipu146183@maims.ac.in>
✅ Deploy Preview for fluentd-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the swapped
reserve_timeexamples on the parser filter docs.Fluentd's
filter_parserkeeps the original event time whenreserve_time true, and uses the parsed time when it is false (default). The docs previously showed the opposite outputs and prose.Changes
reserve_time truevs withoutlib/fluent/plugin/filter_parser.rb(desc 'Keep original event time in the parsed result.')Related
Fixes #439
Test plan
filter_parser.rb(@reserve_timebranch uses originaltime)