Skip to content

Revert "packaging: add -L flag to curl for redirect support " #11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
celalettin1286 wants to merge 1 commit into from
Closed

Revert "packaging: add -L flag to curl for redirect support " #11145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ SCRIPT
$SUDO sh <<SCRIPT
export DEBIAN_FRONTEND=noninteractive
mkdir -p /usr/share/keyrings/
curl -L $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg
curl $RELEASE_KEY | gpg --dearmor > /usr/share/keyrings/fluentbit-keyring.gpg
cat > /etc/apt/sources.list.d/fluent-bit.list <<EOF
Comment on lines 136 to 140

@chatgpt-codex-connector chatgpt-codex-connector Bot Nov 10, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore redirect handling when fetching Debian key

The Ubuntu/Debian branch now calls curl $RELEASE_KEY | gpg --dearmor without -L. When the key endpoint responds with a 301/302 (common when the CDN rotates or when HTTP→HTTPS redirection is enforced), curl will not follow the redirect and instead output the redirect body. gpg --dearmor will fail, leaving an invalid keyring file and causing apt-get update to error. The earlier change you reverted was added to fix exactly this redirect scenario; dropping -L reintroduces the installation failure for any environment where the key URL redirects.

Useful? React with 👍 / 👎.

deb [signed-by=/usr/share/keyrings/fluentbit-keyring.gpg] $RELEASE_URL/${OS}/${CODENAME} ${CODENAME} main
EOF
Expand Down
Loading