Repository navigation
codecs: bound wire decoding and attribute nesting - #33
Merged
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
marked this pull request as ready for review
September 19, 2026 13:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3e339b08b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject excessive nesting before recursive protobuf-C unpacking as well as during MessagePack/OTLP attribute conversion, and free nested attribute values during OTLP encoder cleanup.
The OTLP decoder now performs an explicit-stack, schema-aware wire preflight before calling unpack. This addresses the review finding that a conversion-only limit runs after protobuf-C has already allocated the message tree and leaves recursive unpack/free exposed. The wire preflight bounds the tree to 100 schema messages, rejects malformed lengths/varints, and treats strings, bytes, packed scalars and unknown fields as opaque. Input pointers and offsets are checked before buffer arithmetic.
The separate 32-container attribute budget is retained, with the outer map at depth zero. MessagePack helper signatures remain compatible. Encoder cleanup recursively releases nested AnyValue containers while preserving the protobuf empty-string sentinel.
Validation: all 6 CTest targets pass. The protobuf boundary and OTLP transcoder tests pass Valgrind with zero errors and no leaks. Downstream Fluent Bit tests pass normally and under strict Valgrind. Tests cover 99/100/101 schema-message boundaries, malformed wire fields, and 8/31/32/400 attribute-depth cases for maps, arrays and mixed nesting, including cleanup and continued ingestion.
Compatibility: excessive nesting is rejected. The wire budget includes request and resource/scope wrappers; existing supported attribute-depth tests still pass. No public structure layout or function signature changes.