Repository navigation
fix(pump): separate read routing from tenant webhook writes - #134
Open
olavurellefsen wants to merge 1 commit into
Open
olavurellefsen wants to merge 1 commit into
olavurellefsen wants to merge 1 commit into
Conversation
olavurellefsen
requested review from
allora2026,
jbiskur,
ramattraomnicable and
suuunly
November 1, 2026 16:24
Ramattra reviewSummary: No blocking issues found — small, well-scoped, backward-compatible change. This PR adds an optional
What I checked
Notes (non-blocking)
Automated review by Ramattra — comments only, a human decides on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute must keep its tenant-specific webhook URL for ingestion. Upgrading its pump passes that same URL to SDK catalog/event-source commands, which fail even though the credentials and dedicated service hosts work. A read-only probe with the new data-pump package reproduced the failure in both existing compute deployments; using SDK read hosts succeeds for both identities.
Add
pumpBaseUrlindependently of the existing webhookbaseUrl: omitted preserves legacy single-host routing,nulluses SDK service defaults, and a string selects a read proxy. Webhook writes, provisioning and checkpoints retain their existing behaviour. This complements PR125's optional webhook URL approach for callers that must retain an explicit tenant-specific webhook URL.Tests capture the real data-pump creation options and public webhook write URL in all three modes. Full PostgreSQL-backed Deno suite: 103 passed (256 steps), zero failures. Lint, typecheck and npm ESM/CJS build pass.
Explore recovery is already verified on backend1.43.1 with all four events acknowledged, empty buffers and no duplicate audit or voucher projections. Compute remains on its recovered deployed version while this compatibility change is reviewed; the 3.0.3 consumer upgrade has not been deployed.