Skip to content

Bump Meziantou.Analyzer from 3.0.125 to 3.0.133 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flipbit merged 1 commit into from
Jul 28, 2026
Merged

Bump Meziantou.Analyzer from 3.0.125 to 3.0.133 #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<AnalysisLevel>latest-None</AnalysisLevel>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Meziantou.Analyzer" Version="3.0.125">
<PackageReference Include="Meziantou.Analyzer" Version="3.0.133">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion tests/Tokenizer.Tests/Compilation/Binders/TemplateFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void GivenMultipleCreations_WhenNoName_ThenCounterIncrements()
var definition = new TemplateDefinition { Name = string.Empty };
var t1 = TemplateFactory.Create(1UL, definition);
var t2 = TemplateFactory.Create(2UL, definition);
Assert.NotEqual(t1.Name, t2.Name);
Assert.NotEqual(t1.Name, t2.Name, StringComparer.Ordinal);
Assert.StartsWith("Template_", t1.Name, StringComparison.Ordinal);
Assert.StartsWith("Template_", t2.Name, StringComparison.Ordinal);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Tokenizer.Tests/Diagnostics/DiagnosticIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public void GivenDiagnosticsEnabled_WhenTokenizingWithDecorators_ThenDecoratorEv
var transformerEvent = result.Diagnostics.RawEvents
.First(e => e.Type == TokenizationEventType.TransformerSucceeded);
Assert.NotNull(transformerEvent.DecoratorArgs);
Assert.Contains("yyyy-MM-dd", transformerEvent.DecoratorArgs);
Assert.Contains("yyyy-MM-dd", transformerEvent.DecoratorArgs, StringComparer.Ordinal);
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions tests/Tokenizer.Tests/Reflection/PropertyPathSetter.Collections.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public void GivenStringValues_WhenSetCollectionToStringList_ThenAssigned()
_setter.SetCollection(target, "StringList", values, StringComparison.Ordinal);

// Assert
Assert.Equal(new[] { "alpha", "beta", "gamma" }, target.StringList);
Assert.Equal(new[] { "alpha", "beta", "gamma" }, target.StringList, StringComparer.Ordinal);
}

[Fact]
Expand Down Expand Up @@ -247,7 +247,7 @@ public void GivenSingleValue_WhenSetCollectionToStringList_ThenSingleElementList
_setter.SetCollection(target, "StringList", values, StringComparison.Ordinal);

// Assert
Assert.Equal(new[] { "only" }, target.StringList);
Assert.Equal(new[] { "only" }, target.StringList, StringComparer.Ordinal);
}

// ── Getter-only collections ──────────────────────────────────────────────────
Expand Down
4 changes: 2 additions & 2 deletions tests/Tokenizer.Tests/Reflection/PropertyPathSetter.Pipeline.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public void GivenMultipleTokensWithSameName_WhenAssignToList_ThenAllValuesCollec
var target = result.Assign<CollectionTarget>();

// Assert
Assert.Equal(new[] { "tag1", "tag2", "tag3" }, target.Tags);
Assert.Equal(new[] { "tag1", "tag2", "tag3" }, target.Tags, StringComparer.Ordinal);
}

[Fact]
Expand Down Expand Up @@ -223,7 +223,7 @@ public void GivenMixedScalarAndCollectionTokens_WhenAssign_ThenAllPropertiesPopu

// Assert
Assert.Equal("Alice", target.Name);
Assert.Equal(new[] { "dev", "ops" }, target.Tags);
Assert.Equal(new[] { "dev", "ops" }, target.Tags, StringComparer.Ordinal);
}

// ── Missing property tests ──────────────────────────────────────────────────
Expand Down
2 changes: 1 addition & 1 deletion tests/Tokenizer.Tests/TemplateCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public void GivenCollection_WhenUsedWithLinq_ThenSupportsLinqOperations()
var names = coll.Select(t => t.Name).Order(StringComparer.Ordinal).ToList();

// Assert
Assert.Equal(new[] { "alpha", "beta" }, names);
Assert.Equal(new[] { "alpha", "beta" }, names, StringComparer.Ordinal);
}

[Fact]
Expand Down
54 changes: 27 additions & 27 deletions tests/Tokenizer.Tests/Temporal/DatePatternRecognizerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public void GivenYearDotMonthDotDayWithTime_WhenRecognizing_ThenMatchesAndParses
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy.MM.dd HH:mm:ss", f);
Assert.Contains("yyyy.MM.dd HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -167,7 +167,7 @@ public void GivenYearMonthDayWithTime_WhenRecognizing_ThenMatchesAndParses(strin
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy-MM-dd HH:mm:ss", f);
Assert.Contains("yyyy-MM-dd HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -187,7 +187,7 @@ public void GivenDayMonthNameYearWithTime_WhenRecognizing_ThenMatchesAndParses(s
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd-MMM-yyyy HH:mm:ss", f);
Assert.Contains("dd-MMM-yyyy HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -207,7 +207,7 @@ public void GivenDaynameDayMonthnameYear_WhenRecognizing_ThenMatchesAndParses(st
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dddd d MMMM yyyy", f);
Assert.Contains("dddd d MMMM yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -227,7 +227,7 @@ public void GivenDayMonthnameYearWithTimeAndOffset_WhenRecognizing_ThenMatchesAn
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd MMM yyyy HH:mmzzz", f);
Assert.Contains("dd MMM yyyy HH:mmzzz", f, StringComparer.Ordinal);
Assert.True(DateTimeOffset.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -247,7 +247,7 @@ public void GivenMonthnameDay_Year_WhenRecognizing_ThenMatchesAndParses(string i
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("MMMM d, yyyy", f);
Assert.Contains("MMMM d, yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -268,7 +268,7 @@ public void GivenDayMonthNameYear_WhenRecognizing_ThenMatchesAndParses(string in
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd-MMM-yyyy", f);
Assert.Contains("dd-MMM-yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -288,7 +288,7 @@ public void GivenDayMonthnameYear_WhenRecognizing_ThenMatchesAndParses(string in
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd MMM yyyy", f);
Assert.Contains("dd MMM yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -308,7 +308,7 @@ public void GivenDayFullMonthYear_WhenRecognizing_ThenMatchesAndParses(string in
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd-MMMM-yyyy", f);
Assert.Contains("dd-MMMM-yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -327,7 +327,7 @@ public void GivenDayDotMonthDotYearWithTime_WhenRecognizing_ThenMatchesAndParses
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd.MM.yyyy HH:mm:ss", f);
Assert.Contains("dd.MM.yyyy HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand Down Expand Up @@ -367,7 +367,7 @@ public void GivenKoreanStyle_WhenRecognizing_ThenMatchesAndParses(string input)
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy. MM. dd.", f);
Assert.Contains("yyyy. MM. dd.", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -387,7 +387,7 @@ public void GivenTurkishStyle_WhenRecognizing_ThenMatchesAndParses(string input)
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy-MMM-dd.", f);
Assert.Contains("yyyy-MMM-dd.", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -406,7 +406,7 @@ public void GivenYearSlashMonthSlashDayWithTime_WhenRecognizing_ThenMatchesAndPa
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy/MM/dd HH:mm:ss", f);
Assert.Contains("yyyy/MM/dd HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -425,7 +425,7 @@ public void GivenDaySlashMonthSlashYearWithTime_WhenRecognizing_ThenMatchesAndPa
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd/MM/yyyy HH:mm:ss", f);
Assert.Contains("dd/MM/yyyy HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -444,7 +444,7 @@ public void GivenYearMonthDay_WhenRecognizing_ThenMatchesAndParses(string input)
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy-MM-dd", f);
Assert.Contains("yyyy-MM-dd", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -463,7 +463,7 @@ public void GivenYearDotMonthDotDay_WhenRecognizing_ThenMatchesAndParses(string
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy.MM.dd", f);
Assert.Contains("yyyy.MM.dd", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -482,7 +482,7 @@ public void GivenYearSlashMonthSlashDay_WhenRecognizing_ThenMatchesAndParses(str
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyy/MM/dd", f);
Assert.Contains("yyyy/MM/dd", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -501,7 +501,7 @@ public void GivenDayDotMonthDotYear_WhenRecognizing_ThenMatchesAndParses(string
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd.MM.yyyy", f);
Assert.Contains("dd.MM.yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -520,7 +520,7 @@ public void GivenDaySlashMonthSlashYear_WhenRecognizing_ThenMatchesAndParses(str
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd/MM/yyyy", f);
Assert.Contains("dd/MM/yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -539,7 +539,7 @@ public void GivenDayDashMonthDashYear_WhenRecognizing_ThenMatchesAndParses(strin
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd-MM-yyyy", f);
Assert.Contains("dd-MM-yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -558,7 +558,7 @@ public void GivenCompactWithTime_WhenRecognizing_ThenMatchesAndParses(string inp
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyyMMddHHmmss", f);
Assert.Contains("yyyyMMddHHmmss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -577,7 +577,7 @@ public void GivenCompactDateWithSpaceTime_WhenRecognizing_ThenMatchesAndParses(s
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyyMMdd HH:mm:ss", f);
Assert.Contains("yyyyMMdd HH:mm:ss", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -596,7 +596,7 @@ public void GivenCompactDate_WhenRecognizing_ThenMatchesAndParses(string input)
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("yyyyMMdd", f);
Assert.Contains("yyyyMMdd", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -616,7 +616,7 @@ public void GivenRelaxedDayDotMonthDotYear_WhenRecognizing_ThenMatchesAndParses(
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("d.M.yyyy", f);
Assert.Contains("d.M.yyyy", f, StringComparer.Ordinal);
Assert.True(DateTime.TryParseExact(input, f, CultureInfo.InvariantCulture,
DateTimeStyles.None, out _), $"TryParseExact failed for '{input}' with formats [{string.Join(", ", f)}]");
}
Expand All @@ -637,7 +637,7 @@ public void GivenAmbiguousNumericDate_WhenRecognizingWithInvariantCulture_ThenDe
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("dd/MM/yyyy", f);
Assert.Contains("dd/MM/yyyy", f, StringComparer.Ordinal);
}

[Fact]
Expand All @@ -649,7 +649,7 @@ public void GivenAmbiguousNumericDate_WhenRecognizingWithUsCulture_ThenDefaultsT
// Assert
Assert.True(result);
var f = formats!;
Assert.Contains("MM/dd/yyyy", f);
Assert.Contains("MM/dd/yyyy", f, StringComparer.Ordinal);
}

[Fact]
Expand Down Expand Up @@ -706,6 +706,6 @@ public void GivenIso8601WithOffset_WhenRecognizing_ThenPrioritisedOverPlainYearM

Assert.True(result);
var f = formats!;
Assert.Contains("yyyy-MM-ddTHH:mm:sszzz", f);
Assert.Contains("yyyy-MM-ddTHH:mm:sszzz", f, StringComparer.Ordinal);
}
}
Loading