Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a5f4718
Add screenshot handoff support to ux-design and ui-design workflows
redhat-chai-bot Nov 6, 2026
01ca9d7
Fix coordinator review findings for screenshot handoff
redhat-chai-bot Nov 6, 2026
dce3de5
Reduce publish.md and plan.md to fit 6000-token context budget
redhat-chai-bot Nov 6, 2026
73094e0
Fix publication procedure regressions and coordinator review items A-F
redhat-chai-bot Nov 6, 2026
e67a060
Fix 5 screenshot lifecycle bugs and reduce ingest token count
redhat-chai-bot Nov 6, 2026
6ae7598
Hook ui-design and ux-design script tests into CI
redhat-chai-bot Nov 6, 2026
6ea6efa
Fix 4 review corrections and add executable recipe tests
redhat-chai-bot Nov 6, 2026
ae20e1a
Address 17 inline review comments and root step-sequencing finding
redhat-chai-bot Nov 6, 2026
ea4c545
Fix 6 contract gaps in capture schema, citations, containment, and cl…
redhat-chai-bot Nov 6, 2026
43ac7dd
Fix phase budgets, capture-index all-depth wording, and legacy-embed …
redhat-chai-bot Nov 6, 2026
8ea611f
Restore original semantics in three compressed passages
redhat-chai-bot Nov 6, 2026
d74c5fc
Fix 6 review findings: paths, index accounting, binding, provenance, …
redhat-chai-bot Nov 6, 2026
e54f32d
Refine 6 findings: anchor paths, binding prompt, eligibility factoring
redhat-chai-bot Nov 6, 2026
35ec252
Trim ingest/publish under 6000-token checker limit, align test budgets
redhat-chai-bot Nov 6, 2026
499f763
Fix 7 verified review findings: eligibility, bindings, push recovery
redhat-chai-bot Nov 6, 2026
dc14981
Tighten retry safety, eligibility fail-closed, restore dropped guards
redhat-chai-bot Nov 9, 2026
4ec8d03
Fix commit_paths filter for staged deletions, add pending attempt pro…
redhat-chai-bot Nov 9, 2026
11ed408
Tighten pending_attempt: early check, candidate fields, committed-sta…
redhat-chai-bot Nov 9, 2026
e34aa6b
Fix CI test failure: use git init -b main in test helper
redhat-chai-bot Nov 9, 2026
7575226
T19: call _setup_repo under isolated env instead of duplicating init
redhat-chai-bot Nov 9, 2026
aaefa87
Address 8 review findings: ordering, gating, and state safety
redhat-chai-bot Nov 9, 2026
9984108
Refine PR recovery inputs and publish ordering
redhat-chai-bot Nov 9, 2026
74b732e
Address R5 review: unresolved pairs, binding decisions, PR identity, …
redhat-chai-bot Nov 9, 2026
92fa385
Fix three R5 gaps: child-process quarantine proof, late-branch handli…
redhat-chai-bot Nov 9, 2026
1fe5446
Address R6 review: repair rerun, missing-file status, base check, pus…
redhat-chai-bot Nov 9, 2026
1674a68
Address R6 inline findings: repair gate, upstream freeze, host identi…
redhat-chai-bot Nov 9, 2026
1697b71
Align pending record table with upstream path freeze rules
redhat-chai-bot Nov 9, 2026
d9002dc
Address 5 review findings: index checksum prefix, port identity, PR l…
redhat-chai-bot Nov 9, 2026
254532c
Address R8 review: 7 inline + 2 outside accepted fixes
redhat-chai-bot Nov 9, 2026
48039b0
Fix identity decision ordering: prompt after all prefix checks
redhat-chai-bot Nov 9, 2026
b49a217
Address R9 review: 6 concrete functional/security findings
redhat-chai-bot Nov 9, 2026
05b1335
Fix 4 functional guard holes: exact reader, path mode, normalization,…
redhat-chai-bot Nov 9, 2026
0139ece
Fix 6 R10 flow issues: aggregate gate, Git context, host, template, m…
redhat-chai-bot Nov 9, 2026
f3f86fd
Fix 3 consumer wiring issues: host context, extracted tests
redhat-chai-bot Nov 9, 2026
57f7a6d
Fix 2 screenshot verification gaps: index metadata comparison, pre-co…
redhat-chai-bot Nov 10, 2026
a6bafdc
Fix pre-copy refresh: stop on byte/manifest mismatch, never auto-bless
redhat-chai-bot Nov 10, 2026
8b0dce4
Fix 5 review findings: binding rule, transport scheme, frozen SHA pus…
redhat-chai-bot Nov 10, 2026
bc9e205
Refine 4 gap fulfillments: Notes binding, caption skip, verified API,…
redhat-chai-bot Nov 10, 2026
8c12106
Fix 6 review findings: manifest uniqueness, rewrite guard, context ro…
redhat-chai-bot Nov 10, 2026
dd4b1d1
Refine 3 R13 fulfillments: reply classification, CWD proof, instance …
redhat-chai-bot Nov 10, 2026
b231fc0
Fix 4 R14 review findings: repair manifest reload, late inspection ha…
redhat-chai-bot Nov 10, 2026
61ccc99
Refine R14: §4 repair runs §2, expected_sha conditional, new-PR deriv…
redhat-chai-bot Nov 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,5 @@ jobs:
- run: python3 -m unittest discover -s triage/scripts -p 'test_*.py' -v
- run: python3 -m unittest discover -s skills/report-bug/scripts -p 'test_*.py' -v
- run: python3 -m unittest discover -s design/scripts -p 'test_*.py' -v
- run: python3 -m unittest discover -s ui-design/scripts -p 'test_*.py' -v
- run: python3 -m unittest discover -s ux-design/scripts -p 'test_*.py' -v
2 changes: 2 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ _shared/
phase-override-resolution.md # Project-level phase override lookup and activation
record-manual-edit.md # Tier 3 manual-edit attribution (wraps capture recipe)
render-provenance-footer.md # Render durable footer into docs-repo markdown before commit
screenshot-inspection.md # Screenshot identity verification and visual inspection (used by ui-design)
screenshot-publish-stage.md # Owned-path allowlist, staging, and commit for screenshot publishes (used by ux-design)
self-review-gate.md # Pre-PR self-review quality gate (used by bugfix, implement, e2e, cve-fix)
validation-gate.md # Pre-commit build/test/lint discovery gate (used by bugfix)
```
Expand Down
374 changes: 374 additions & 0 deletions _shared/recipes/screenshot-inspection.md

Large diffs are not rendered by default.

406 changes: 406 additions & 0 deletions _shared/recipes/screenshot-publish-stage.md

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions ui-design/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ graph TD
| Docs repository (configured) | For `/ingest`, `/publish` | Load upstream PRD, design doc, UX handoff; publish UI design |
| GitHub CLI (`gh`) | For `/publish`, `/respond` | Create PRs, post review comments |
| Git | Yes | Branch management, commits |
| Runtime image-reading capability | For screenshot inspection | Open and inspect image files |
| Runtime binary-download capability | For external screenshot inspection | Retrieve image bytes from URLs |

## Inputs

Expand All @@ -47,6 +49,7 @@ The workflow draws from multiple published sources — never from another workfl
| Context path | User-provided filesystem path (non-Jira flow only) | No — used when starting from a local document |
| Description | User-provided text (non-Jira flow only) | No — used when starting from a textual description |
| UX handoff (`handoff.md`) | Docs repo (from `ux-design` workflow) | No — optional for purely technical work |
| UX screenshots (`screenshots/` or external URLs) | Docs repo (repo-local files or immutable external HTTPS refs alongside `handoff.md`) | No — present only when evaluation captured screenshots |
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
| PRD (`prd.md`) | Docs repo (from `prd` workflow) | Yes |
| Design document (`design.md`) | Docs repo (from `design` workflow) | Yes |
| `AGENTS.md` / `UI-ARCHITECTURE.md` | Project root | If available |
Expand Down Expand Up @@ -80,6 +83,8 @@ Jira).
/ui-design:ingest EDM-1234
→ fetches the [UI] story from Jira
→ follows references to load UX handoff, PRD, design doc from docs repo
→ if UX handoff has screenshots, opens and visually inspects each image
→ records screenshot observations (visual details, text/image consistency)
→ reads AGENTS.md, UI-ARCHITECTURE.md
→ explores UI codebase (components, hooks, routes, state, tests)
→ explores backend API (types, endpoints, OpenAPI specs)
Expand Down
2 changes: 1 addition & 1 deletion ui-design/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: ui-design
version: 0.1.0
version: 0.2.0
description: >-
UI design workflow that takes a [UI] Jira story and optional UX handoff artifact,
produces a component decomposition with hook design, state management,
Expand Down
7 changes: 7 additions & 0 deletions ui-design/guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
- **Persona-aware decomposition is required.** When the UX handoff identifies multiple user groups with distinct views or permissions, the component architecture must address conditional rendering, permission gates, and shared vs. persona-specific components explicitly.
- **Data annotations drive API review.** Every `Unknown` or `API` source type in the UX handoff's Data Annotations table must be resolved to a specific API endpoint and field — or flagged as a gap.
- **Accessibility is architectural.** ARIA roles, keyboard navigation, and focus management are designed alongside components, not bolted on later.
- **Screenshots are visual evidence, not runtime verification.** When UX
handoff screenshots are available, cite them for layout and visual-state
decisions. Screenshots show rendered presentation; they do not verify
keyboard navigation, accessibility compliance, API behavior, or runtime
state management. Flag text/image discrepancies rather than silently
choosing one source or inventing behavior to reconcile them.
- **Tests validate behavior, not implementation.** The testing strategy describes what user-facing behaviors to verify, using the project's existing test framework and patterns.

## Shared Content Rules
Expand All @@ -21,6 +27,7 @@ artifacts and published output from this workflow.
## Hard Limits

- No fabricated requirements. Every component, hook, and route must trace to a UX handoff element, design document constraint, PRD requirement, or user direction.
- No fabricated visual observations. When screenshots cannot be inspected (tool unavailability, unreadable files), report the limitation — do not invent observations from captions, alt text, or filenames.
- No publishing (creating PRs, posting comments) without explicit user approval.
- No Jira modifications without explicit user approval and a dry-run preview first.
- **No scope reduction.** Never silently simplify, defer to "v2", use "placeholder", or say "future enhancement" to reduce scope. If scope won't fit, propose a split — don't reduce.
Expand Down
Loading
Loading