docs(doc-review): 43 documentation fixes from the 2026-09-18 → 2026-09-22 diff audit - #428
Open
flashduty[bot] wants to merge 1 commit into
Open
flashduty[bot] wants to merge 1 commit into
flashduty[bot] wants to merge 1 commit into
Conversation
…diff audit (2026-09-18 → 2026-09-22) Incremental doc-review over the window since the last successful run. - AI SRE: artifact pinning, real-content card thumbnails, the narrowed publish_artifact type gate and the artifact_id/if_revision update contract; the 相似故障合并分析 fan-in switch and its run-history surface; the reply-only IM delivery contract plus mid-turn progress messages; the agent_dispatch environment argument and cross-environment MCP catalog. - On-call: configurable Jira 状态映射 and the 故障属性 field-mapping sources; the subscription-expired behaviour documented once on pricing.mdx with short notes on the surfaces it gates. - Monitors: the data source console now exposes 负责团队 / 可查询团队, the new read-only drawer and list tags, and the removed 'Ask in AI SRE' entry. - Developer: CLI operation counts (340->338 spec, 336->334 generated), the Go SDK AlertRuleV2 investigation_targets rework, and two API-catalog corrections. zh written first, en derived. mint broken-links: no broken links.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-09-22
Mode: diff (since
2026-09-18T08:02:02Z) · Window: last successful run 2026-09-18T08:02Z → 2026-09-22T08:03ZScope: all modules · Findings: 46 total — 0 high, 20 medium, 26 low
Applied: 43 findings, 52 files touched (26 zh/en page pairs) · Not applied: 1 (d001) · Cross-repo follow-ups: 2
Changes
ai-sre/artifacts.mdxai-sre/artifacts.mdxai-sre/artifacts.mdxai-sre/artifacts.mdxai-sre/artifacts.mdxai-sre/automations.mdxai-sre/automations.mdxai-sre/automations.mdxai-sre/im.mdxai-sre/im.mdxai-sre/agents.mdxai-sre/mcp.mdxai-sre/mcp.mdxai-sre/environments.mdxai-sre/environments.mdxai-sre/sessions.mdxai-sre/sessions.mdxai-sre/skills.mdxon-call/integration/webhooks/jira-sync.mdxon-call/integration/webhooks/jira-sync.mdxon-call/integration/webhooks/alert-webhook.mdxon-call/integration/webhooks/incident-webhook.mdxplatform/pricing.mdxon-call/analytics/insights.mdxon-call/statuspage/statuspage.mdxplatform/team-members.mdxplatform/permission-design.mdxmonitors/data-sources/data-sources.mdxmonitors/data-sources/data-sources.mdxmonitors/data-sources/data-sources.mdxmonitors/data-sources/data-sources.mdxmonitors/explore/explore.mdxon-call/integration/sso/keycloak.mdxon-call/quickstart/mobile-app.mdxrum/others/data-collection.mdxdeveloper/cli.mdxdeveloper/cli.mdxon-call/comparison/vs-pagerduty.mdxdeveloper/go-sdk.mdxdeveloper/go-sdk.mdxdeveloper/go-sdk.mdxopenapi/api-catalog.mdxopenapi/api-catalog.mdxEvery edit was written from source read at
origin/main(or the fc-foundation-app submodule'sorigin/main). 52 files, 26 zh + 26 en.Review checklist
oncall_incident_merge_similardefaults on (*bool, nil→true inlogic/automation/service.go), and the CLI counts (340→338 spec operations, 336→334 generated) were recounted fromgo-flashduty/openapi/openapi.en.jsonpaths×methods andflashduty-cli/internal/cli/zz_generated_manifest.go.f013(Monitors-only catalog rows) andf027are the most judgement-dependent edits.f027's original premise was falsified during the fix pass: the channel-integrationrbacis a 2-element array andAuth.tsx:190defaultsmode='or'withhasPermissionusing.some(), so it is an or, not an added requirement. The verified semantics were documented instead.f007's suggested wording forblockedwas likewise contradicted by code and replaced with whatmodel/automation/tables.gosays.src/i18n.tsfalls back tozh_CNfor several new banners), the en page describes the message instead of quoting an invented translation.changelog.mdx— see Not applied.Cross-repo follow-ups (flashduty-website)
d002 · medium/missing_coverage · target
content/changelog/d003 · medium/missing_coverage · target
lib/integrations/catalog.tsFurther follow-ups outside both repos (surfaced by writers; not actionable from a docs PR):
api-reference/*must be regenerated for the new artifact endpoints (/safari/artifact/gallery/pin,/gallery/unpin): the fc-pgy registry rows exist (artifact:write:pin/artifact:write:unpin) butgrep -c gallery/pin api-reference/*.jsonis 0, so the new 产物 rows carry plain paths instead of links. Owner:api-review.AutomationRunItem.joined_session_id/joined_session_nameinapi-reference/safari.openapi.*.json.兼容 POST /monit/rule/importsurvives in the generated specs (api-reference/monitors.openapi.zh.json:3069,api-reference/openapi.zh.json:2491, en mirrors) and upstream ingo-flashduty'sAlertRuleExportListResponsedescription onorigin/main. Source-side fix + regeneration.fc-foundation-appfrontendRESERVED_KEYS(src/Packages/ai-sre/src/utils/envVars.ts) omitsFLASHDUTY_DOCS_URL, so a cloud environment template that sets it is rejected only at save time, not in the form.Mapping warnings
fc-foundation-app— src/Packages/saas/pages/Dashboard (mapped to the statuspage module)the status-page console UI actually lives in src/Packages/saas/pages/StatusPage; pages/Dashboard is the analytics/insights dashboard (on-call module). Verified on origin/main: both directories exist side by side. This stale path routed the on-call dashboard hunks to the statuspage batch and left the real StatusPage changes unreviewed; covered this round by a manual pass.
flashduty-docs— zh/on-call/quickstart/comparison.mdx (derivative_surfaces.comparison_page)the comparison pages live in zh/on-call/comparison/{vs-pagerduty,vs-opsgenie}.mdx and en/on-call/comparison/
flashduty-docs— .cursor/skills/translate-zh-to-en/glossary.md and .cursor/skills/polish-document/standards.mdno .cursor/ directory exists; the skills moved to .claude/skills/translate-zh-to-en/ and .claude/skills/polish-document/, plus the root glossary.md
fc-safari— logic/tool/, logic/middleware/, logic/automation/, logic/artifact/, logic/agent/, logic/task/, logic/share/, logic/marketplace/, model/artifact/, types/mapping.yaml's ai-sre module lists only cmd/api + a subset of logic/*; the window touched ~14k lines across fc-safari of which only ~5k were mapped. Five extra batches covered logic/tool, logic/middleware, logic/automation, logic/agent and logic/artifact+model/artifact+logic/share this round, producing 12 findings (im.mdx, automations.mdx, agents.mdx, mcp.mdx, artifacts.mdx). Widen the module's paths.
Not applied
<Update>block is 2026-09-16, so none of this window's user-facing features (artifact pinning, configurable Jira status mapping, similar-incident fan-in, the subscription-expired gate, IM progress replies) appear there. No entry was written: the changelog is dated by release, and whether this window's merges have shipped cannot be established from code onmain, so dating an entry would be a guess. A human should decide the grouping and the date.zh/en/changelog/changelog.mdx:46— the 2026-09-16 bullet still says the console data source form has no inputs for 负责团队 / 可查询团队, whichFormDrawer.tsx:288-309now contradicts. Left untouched deliberately: it is a dated historical entry and rewriting it would falsify a past release note. The live reference page (monitors/data-sources/data-sources.mdx) was corrected under f028. The same tension exists atchangelog.mdx:464—可发布为产物的文件类型不再限于 HTML 与 Markdownholds for the console button but not for thepublish_artifacttool after f003.sp1-002(analytics-board AI-governance default question) — dropped as marginal: the mechanism is already documented generically inai-sre/sessions.mdx; only the entry-page enumeration would change.