feat: serve Prometheus label values as a curated command - #191
Merged
Merged
Conversation
monit-prometheus-read-label-values carries a path parameter and a non-enveloped response, so it is excluded from generation. Bump go-flashduty to the commit that adds the hand-written SDK method, and attach a curated command at the operation's path-name under the monit group: a positional label name, a required --data-source-id flag for the X-DSID header, and standard result rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the curated command
flashduty monit prometheus-api-v1-label-{label_name}-values <label_name> --data-source-id <id>on top of the newDataSourcesService.ReadPrometheusLabelValuesSDK method. The operation has a path parameter and a non-enveloped response, so it is excluded from generation.monit, soTestEveryOperationHasPathCommandfinds it.curatedOperationIDslists the operation.Tests
monit_prometheus_label_values_test.gocovers path, method and header, the missing-flag rejection, and a data source error.make test(includingTestEveryOperationHasPathCommandandTestGeneratorTargetsFullSpec),make check-cards,make buildandmake lintpass.__name__andjobreturn real label values.