ci: build hvigor-plugin before assembling the OHPM packages - #41
Merged
Merged
Conversation
The demo's hvigorfile imports the in-repo symbol upload plugin from its build output, and hvigor loads every module's hvigorfile even when it assembles a single HAR. The build output is not committed, so on a clean checkout no module built and the publish job failed before packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OHPM publish job fails at "Build HAR packages" on a clean checkout:
entry/hvigorfile.tsimports the in-repo symbol upload plugin fromhvigor-plugin/dist, which is git-ignored build output. hvigor loads every module's hvigorfile even for--mode modulebuilds, so none of the SDK HARs build until the plugin has been compiled. This adds a step that runsnpm ci && npm run buildinhvigor-pluginbefore the HAR loop.Verified on a fresh checkout with the same command-line tools the job uses: without the plugin build
assembleHarforflashcat_corefails with the error above; after it, all five modules (core, rum, crash, trace, axios) build and produce their.har.🤖 Generated with Claude Code